Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Sep 30, 2025

Description

This change adds a lightweight “advisories” mechanism to section configs and ships the first advisory to help operators satisfy some of the CKS prerequisites.
The functionality can be disabled by adding advisoriesDisabled as true in config.json.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

ui-feature-advisory.mp4

How Has This Been Tested?

How did you try to break this feature and the system with this change?

This change adds a lightweight “advisories” mechanism to section configs and ships the first advisory to help operators satisfy some of the CKS prerequisites.

Signed-off-by: Abhishek Kumar <[email protected]>
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.54%. Comparing base (5f9e131) to head (745055d).
⚠️ Report is 35 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11763      +/-   ##
============================================
- Coverage     17.55%   17.54%   -0.01%     
- Complexity    15537    15538       +1     
============================================
  Files          5910     5912       +2     
  Lines        529336   529489     +153     
  Branches      64654    64673      +19     
============================================
+ Hits          92904    92910       +6     
- Misses       425975   426123     +148     
+ Partials      10457    10456       -1     
Flag Coverage Δ
uitests 3.58% <ø> (-0.01%) ⬇️
unittests 18.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
@apache apache deleted a comment from blueorangutan Sep 30, 2025
@apache apache deleted a comment from blueorangutan Sep 30, 2025
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Signed-off-by: Abhishek Kumar <[email protected]>
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11763 (QA-JID-769)

@shwstppr shwstppr requested a review from Copilot October 1, 2025 07:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a lightweight "advisories" mechanism to section configurations that displays warnings and quick-fix actions to help operators satisfy CKS (CloudStack Kubernetes Service) prerequisites. The feature adds advisory alerts with actionable buttons to guide users through common configuration issues.

  • Adds advisory system with condition evaluation and quick-fix actions
  • Implements three CKS-specific advisories for compute offerings, Kubernetes versions, and endpoint URL configuration
  • Provides dismissible alerts with primary/secondary action buttons

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ui/src/views/AutogenView.vue Integrates AdvisoriesView component into the main view
ui/src/config/section/compute.js Adds three CKS advisories with conditions and fix actions
ui/src/config/router.js Extends router metadata to include advisories configuration
ui/src/components/view/AdvisoriesView.vue Core advisory component with alert rendering and action handling
ui/src/api/index.js Adds getBaseUrl utility function
ui/public/locales/en.json Adds localization strings for advisory messages and actions
Comments suppressed due to low confidence (1)

ui/src/components/view/AdvisoriesView.vue:1

  • Use 'const' instead of 'var' for variable declaration to follow modern JavaScript best practices and maintain consistency with the rest of the codebase.
// Licensed to the Apache Software Foundation (ASF) under one

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

shwstppr and others added 4 commits October 1, 2025 13:10
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
@DaanHoogland
Copy link
Contributor

cool idea!

@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@apache apache deleted a comment from blueorangutan Nov 12, 2025
@apache apache deleted a comment from blueorangutan Nov 12, 2025
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11763 (QA-JID-797)

@shwstppr shwstppr marked this pull request as ready for review November 12, 2025 11:53
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

filters: child.filters,
params: child.params ? child.params : {},
columns: child.columns,
advisories: !vueProps.$config.advisoriesDisabled ? child.advisories : undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit of a nitpick, but I would reverse the setting, i.e. advisoriesEnabled (default true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants