Skip to content

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Oct 3, 2025

Description

This PR fixes #11502
Removal of offerings is skipped if it is in use by any Instance.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.00%. Comparing base (c631d6a) to head (fcbfe26).
⚠️ Report is 3 commits behind head on 4.20.

❗ There is a different number of reports uploaded between BASE (c631d6a) and HEAD (fcbfe26). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c631d6a) HEAD (fcbfe26)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.20   #11780       +/-   ##
=============================================
- Coverage     16.17%    4.00%   -12.17%     
=============================================
  Files          5656      402     -5254     
  Lines        498242    32661   -465581     
  Branches      60458     5807    -54651     
=============================================
- Hits          80584     1309    -79275     
+ Misses       408686    31199   -377487     
+ Partials       8972      153     -8819     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudo87 idea seems correct, implementation not

@sudo87 sudo87 marked this pull request as draft October 3, 2025 08:52
@sudo87 sudo87 marked this pull request as ready for review October 6, 2025 12:13
@sudo87
Copy link
Collaborator Author

sudo87 commented Oct 6, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants