PR #11778 with changes for main branch

[rohityadavcloud]

This continues PR #11778, but for main branch with 4.22 specific changes.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[rohityadavcloud]

I've used @weizhouapache 's PR to add some custom changes -- but we could in theory just use the 4.20.2.0 template for main/4.22, I don't notice huge difference b/w 4.20 & main for systemvmtemplate use -- please advise @harikrishna-patnala @weizhouapache

Kicked build job for this PR, if/when successful (in 1-2 hrs+) the templates will be avaliable here: https://build.yadav.cloud/systemvm/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.50%. Comparing base (b09f3e8) to head (b265530).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11781      +/-   ##
============================================
- Coverage     17.50%   17.50%   -0.01%     
- Complexity    15427    15428       +1     
============================================
  Files          5894     5894              
  Lines        526880   526880              
  Branches      64338    64338              
============================================
- Hits          92243    92242       -1     
  Misses       424260   424260              
- Partials      10377    10378       +1     

Flag	Coverage Δ
uitests	3.61% <ø> (ø)
unittests	18.56% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

I've used @weizhouapache 's PR to add some custom changes -- but we could in theory just use the 4.20.2.0 template for main/4.22, I don't notice huge difference b/w 4.20 & main for systemvmtemplate use -- please advise @harikrishna-patnala @weizhouapache

Kicked build job for this PR, if/when successful (in 1-2 hrs+) the templates will be avaliable here: https://build.yadav.cloud/systemvm/

thanks @rohityadavcloud

we do need to rebuild 4.22 system templates due to #11726

[weizhouapache]

lgtm

[vishesh92]

lgtm

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15309

[harikrishna-patnala]

@blueorangutan test matrix

[blueorangutan]

@harikrishna-patnala a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-14558)

[blueorangutan]

[SF] Trillian Build Failed (tid-14557)

[blueorangutan]

[SF] Trillian Build Failed (tid-14555)