small refactors on account manager

[DaanHoogland]

Description

This PR does some small refactors encountered during trouble shooting. ...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.50%. Comparing base (36cfd76) to head (9dc2f0d).
⚠️ Report is 337 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/main/java/com/cloud/user/AccountManagerImpl.java	9.09%	10 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11784      +/-   ##
============================================
+ Coverage     16.17%   17.50%   +1.33%     
- Complexity    13296    15426    +2130     
============================================
  Files          5656     5894     +238     
  Lines        498219   526879   +28660     
  Branches      60451    64338    +3887     
============================================
+ Hits          80579    92243   +11664     
- Misses       408672   424259   +15587     
- Partials       8968    10377    +1409     

Flag	Coverage Δ
uitests	3.61% <ø> (-0.40%)	⬇️
unittests	18.56% <9.09%> (+1.53%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15282

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[Copilot]

Pull Request Overview

This PR performs small refactoring improvements to the AccountManagerImpl class to enhance code readability and maintainability. The changes include simplifying conditional logic, extracting reusable methods, and updating logging patterns.

• Simplified multiple conditional statements to use direct return expressions
• Extracted domain ID calculation logic into a reusable private method
• Updated logging to use parameterized format and modern charset handling

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[blueorangutan]

[SF] Trillian test result (tid-14531)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52946 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11784-t14531-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_13_retrieve_vr_default_files	Error	1.11	test_diagnostics.py
test_14_retrieve_vr_one_file	Error	1.12	test_diagnostics.py
test_15_retrieve_ssvm_default_files	Error	1.13	test_diagnostics.py
test_16_retrieve_ssvm_single_file	Error	1.11	test_diagnostics.py
test_17_retrieve_cpvm_default_files	Error	0.12	test_diagnostics.py
test_18_retrieve_cpvm_single_file	Error	1.14	test_diagnostics.py