-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update CI workflow to use Ubuntu 24.04 and comply to PEP 625 #11873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11873 +/- ##
=============================================
+ Coverage 16.18% 18.44% +2.25%
- Complexity 13303 16940 +3637
=============================================
Files 5657 5977 +320
Lines 498464 607323 +108859
Branches 60491 91693 +31202
=============================================
+ Hits 80689 112008 +31319
- Misses 408794 483311 +74517
- Partials 8981 12004 +3023
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
shall we target to 4.20 ? it has the same issue I think |
4027aae to
103629b
Compare
vishesh92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
with setuptools <=69.2.0 with setuptools >=69.3.0 |
|
|
oob management now fails. will we merge like this @vishesh92 @weizhouapache ? |
let's merge - it is much much better than failures |
Agree with @weizhouapache. |
ok, merging and looking at the simulator for this error next. |
after gha are done raging on |
* 4.20: Update CI workflow to use Ubuntu 24.04 (#11873)



Description
This PR updates the ci workflow to use newer ubuntu and allow for lower case archive of {M}arvin-x.y.z.tar.gz
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?