Skip to content

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Oct 20, 2025

Description

This PR updates the ci workflow to use newer ubuntu and allow for lower case archive of {M}arvin-x.y.z.tar.gz

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.44%. Comparing base (03a4b9f) to head (103629b).
⚠️ Report is 1 commits behind head on 4.20.

Additional details and impacted files
@@              Coverage Diff              @@
##               4.20   #11873       +/-   ##
=============================================
+ Coverage     16.18%   18.44%    +2.25%     
- Complexity    13303    16940     +3637     
=============================================
  Files          5657     5977      +320     
  Lines        498464   607323   +108859     
  Branches      60491    91693    +31202     
=============================================
+ Hits          80689   112008    +31319     
- Misses       408794   483311    +74517     
- Partials       8981    12004     +3023     
Flag Coverage Δ
uitests 4.30% <ø> (+0.29%) ⬆️
unittests 19.52% <ø> (+2.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland changed the title Update CI workflow to use Ubuntu 24.04 Update CI workflow to use Ubuntu 24.04 and comply to PEP 625 Oct 21, 2025
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache
Copy link
Member

shall we target to 4.20 ? it has the same issue I think
@DaanHoogland

@DaanHoogland DaanHoogland changed the base branch from main to 4.20 October 21, 2025 09:26
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache
Copy link
Member

with setuptools <=69.2.0

4.22.0.0 -> Marvin-4.22.0.0.tar.gz
4.22.1.0 -> Marvin-4.22.1.0.tar.gz
4.22.1.2 -> Marvin-4.22.1.2.tar.gz

with setuptools >=69.3.0

4.22.0.0 -> marvin-4.22.tar.gz
4.22.1.0 -> marvin-4.22.1.tar.gz
4.22.1.2 -> marvin-4.22.1.2.tar.gz

@DaanHoogland DaanHoogland marked this pull request as ready for review October 21, 2025 10:44
@DaanHoogland DaanHoogland reopened this Oct 21, 2025
@sonarqubecloud
Copy link

@DaanHoogland
Copy link
Contributor Author

oob management now fails. will we merge like this @vishesh92 @weizhouapache ?

@weizhouapache
Copy link
Member

oob management now fails. will we merge like this @vishesh92 @weizhouapache ?

let's merge - it is much much better than failures

@vishesh92
Copy link
Member

vishesh92 commented Oct 21, 2025

oob management now fails. will we merge like this @vishesh92 @weizhouapache ?

let's merge - it is much much better than failures

Agree with @weizhouapache.
I am confused why this would happen with a simulator env for OOB. The error is below which suggests some other issue with the test itself or dependence of simulator env on some services installed on the server.

Exception: Job failed: {accountid : '9fa6b73d-ae71-11f0-a695-000d3a3af5cc', account : 'admin', domainid : '9fa680cb-ae71-11f0-a695-000d3a3af5cc', domainpath : 'ROOT', userid : '9fa6eae9-ae71-11f0-a695-000d3a3af5cc', cmd : 'org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd', jobstatus : 2, jobprocstatus : 0, jobresultcode : 530, jobresulttype : 'object', jobresult : {errorcode : 530, errortext : 'Out-of-band Management action [STATUS] on Host {"id":1,"name":"SimulatedAgent.74406bf4-ca73-4814-8e76-0c24917ac58b","type":"Routing","uuid":"534a6c4d-dda7-405f-81d9-ac0572acd29f"} failed with error: Loading IANA PEN Registry...\nUnable to Get Channel Cipher Suites\nSet Session Privilege Level to ADMINISTRATOR failed\nError: Unable to establish IPMI v2 / RMCP+ session\n'}, jobinstancetype : 'Host', jobinstanceid : '534a6c4d-dda7-405f-81d9-ac0572acd29f', created : '2025-10-21T11:54:00+0000', completed : '2025-10-21T11:54:06+0000', jobid : '9abba1a8-8a71-430a-95ef-f44fe2708fcf'}

@DaanHoogland
Copy link
Contributor Author

oob management now fails. will we merge like this @vishesh92 @weizhouapache ?

let's merge - it is much much better than failures

Agree with @weizhouapache. I am confused why this would happen with a simulator env for OOB. The error is below which suggests some other issue with the test itself or dependence of simulator env on some services installed on the server.

Exception: Job failed: {accountid : '9fa6b73d-ae71-11f0-a695-000d3a3af5cc', account : 'admin', domainid : '9fa680cb-ae71-11f0-a695-000d3a3af5cc', domainpath : 'ROOT', userid : '9fa6eae9-ae71-11f0-a695-000d3a3af5cc', cmd : 'org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd', jobstatus : 2, jobprocstatus : 0, jobresultcode : 530, jobresulttype : 'object', jobresult : {errorcode : 530, errortext : 'Out-of-band Management action [STATUS] on Host {"id":1,"name":"SimulatedAgent.74406bf4-ca73-4814-8e76-0c24917ac58b","type":"Routing","uuid":"534a6c4d-dda7-405f-81d9-ac0572acd29f"} failed with error: Loading IANA PEN Registry...\nUnable to Get Channel Cipher Suites\nSet Session Privilege Level to ADMINISTRATOR failed\nError: Unable to establish IPMI v2 / RMCP+ session\n'}, jobinstancetype : 'Host', jobinstanceid : '534a6c4d-dda7-405f-81d9-ac0572acd29f', created : '2025-10-21T11:54:00+0000', completed : '2025-10-21T11:54:06+0000', jobid : '9abba1a8-8a71-430a-95ef-f44fe2708fcf'}

ok, merging and looking at the simulator for this error next.

@DaanHoogland
Copy link
Contributor Author

… merging and ...

after gha are done raging on

@DaanHoogland DaanHoogland merged commit a6068a8 into 4.20 Oct 21, 2025
104 of 109 checks passed
@DaanHoogland DaanHoogland deleted the DaanHoogland-patch-7 branch October 21, 2025 14:22
DaanHoogland pushed a commit that referenced this pull request Oct 22, 2025
* 4.20:
  Update CI workflow to use Ubuntu 24.04 (#11873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants