-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix OOB test failures in ci.yml github actions #11887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes out-of-band (OOB) test failures in the CI/CD pipeline by configuring the IPMI tool with the required -C3 flag. The changes add a new setup step that creates a wrapper script for ipmitool to automatically include the -C3 cipher suite parameter, which is necessary for proper IPMI communication in the test environment.
Key Changes:
- Adds a new GitHub Actions workflow step to configure IPMI tool wrapper
- Creates a backup of the original
ipmitoolbinary and implements a wrapper script that automatically passes the-C3flag
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11887 +/- ##
=========================================
Coverage 16.18% 16.18%
- Complexity 13304 13305 +1
=========================================
Files 5657 5657
Lines 498464 498464
Branches 60491 60491
=========================================
+ Hits 80686 80694 +8
+ Misses 408803 408789 -14
- Partials 8975 8981 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
looks good 👍
@vishesh92 |
bbe3ea9 to
5d9bc72
Compare
|
@weizhouapache done. |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
All checks have passed, thanks for the fix @vishesh92 merging |
* 4.20: Fix OOB test failures in ci.yml github actions (#11887)

Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?