Skip to content

Conversation

@vishesh92
Copy link
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes out-of-band (OOB) test failures in the CI/CD pipeline by configuring the IPMI tool with the required -C3 flag. The changes add a new setup step that creates a wrapper script for ipmitool to automatically include the -C3 cipher suite parameter, which is necessary for proper IPMI communication in the test environment.

Key Changes:

  • Adds a new GitHub Actions workflow step to configure IPMI tool wrapper
  • Creates a backup of the original ipmitool binary and implements a wrapper script that automatically passes the -C3 flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.18%. Comparing base (a6068a8) to head (5d9bc72).
⚠️ Report is 1 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #11887   +/-   ##
=========================================
  Coverage     16.18%   16.18%           
- Complexity    13304    13305    +1     
=========================================
  Files          5657     5657           
  Lines        498464   498464           
  Branches      60491    60491           
=========================================
+ Hits          80686    80694    +8     
+ Misses       408803   408789   -14     
- Partials       8975     8981    +6     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member

looks good 👍

image

@vishesh92
can you re-target to 4.20 ?
the pre-commit check failure needs to be fixed (trailing-whitespace)

@vishesh92 vishesh92 changed the base branch from main to 4.20 October 22, 2025 09:23
@vishesh92
Copy link
Member Author

@weizhouapache done.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Member

All checks have passed, thanks for the fix @vishesh92

merging

@weizhouapache weizhouapache merged commit a839e25 into apache:4.20 Oct 22, 2025
26 checks passed
@weizhouapache weizhouapache deleted the fixup-oob-gha-ci branch October 22, 2025 12:50
DaanHoogland pushed a commit that referenced this pull request Oct 23, 2025
* 4.20:
  Fix OOB test failures in ci.yml github actions (#11887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants