Skip to content

Conversation

@nvazquez
Copy link
Contributor

Description

This PR fixes a condition where memory values can be displayed twice on the InfoCard view, for example at the Virtual Machine view:

image

After the fix:

Screenshot 2025-10-22 at 11 13 48 PM

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@nvazquez
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11896 (QA-JID-780)

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (8bbe253) to head (0d5c3d7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11896   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
+ Complexity    15532    15531    -1     
=========================================
  Files          5909     5909           
  Lines        529012   529012           
  Branches      64604    64604           
=========================================
+ Hits          92913    92914    +1     
+ Misses       425652   425651    -1     
  Partials      10447    10447           
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@harikrishna-patnala
Copy link
Contributor

verified on simulator env.

image

@harikrishna-patnala harikrishna-patnala merged commit 2fcf962 into apache:main Oct 23, 2025
26 of 27 checks passed
@harikrishna-patnala harikrishna-patnala deleted the 422-fix-duplicate-memory-infocard branch October 23, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants