Skip to content

Conversation

@nvazquez
Copy link
Contributor

Description

This PR fixes an UI issue when triggering the 'Upgrade router template' operation:

image

Despite the UI error, the process was started properly and the router template was updated, but this PR addresses the error that causes the error displayed.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Upgrade from 4.20.2
  • Upgrade routers template

How did you try to break this feature and the system with this change?

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (b1851ba) to head (9ba660a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...src/main/java/com/cloud/api/ApiResponseHelper.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11901   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15533    15535    +2     
=========================================
  Files          5909     5909           
  Lines        529013   529007    -6     
  Branches      64605    64605           
=========================================
+ Hits          92912    92923   +11     
+ Misses       425652   425634   -18     
- Partials      10449    10450    +1     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15534

Copy link
Collaborator

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rosi-shapeblue rosi-shapeblue self-assigned this Oct 24, 2025
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Copy link
Collaborator

@rosi-shapeblue rosi-shapeblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The UI issue has been fixed, template updated successfully

Screencast.from.2025-10-24.11-03-49.webm
Screenshot from 2025-10-24 11-05-01 Screenshot from 2025-10-24 11-05-43 screencapture-10-0-34-78-8080-client-2025-10-24-11_05_56

@harikrishna-patnala harikrishna-patnala merged commit 7ef5db2 into apache:main Oct 24, 2025
26 of 27 checks passed
@harikrishna-patnala harikrishna-patnala deleted the 422-fix-upgrade-router-template-ui branch October 24, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants