Fix CKS cluster creation not honoring the CKS ISO arch

[nvazquez]

Description

This PR fixes the CKS cluster creation logic to honor the CKS ISO arch type.

Fixes: #11734

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested on multi-arch zone

• Registered CKS ISOs for x86_64 and arm64 with their corresponding arch value set
• Set system.vm.preferred.architecture = aarch64
• Create CKS cluster selecting the CKS ISO for arm64 -> Observe the CKS nodes and VR are deployed on arm64 hosts.

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (b1851ba) to head (1088f39).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
...KubernetesClusterResourceModifierActionWorker.java	0.00%	12 Missing ⚠️
...dstack/api/response/KubernetesClusterResponse.java	0.00%	6 Missing ⚠️
...er/actionworkers/KubernetesClusterScaleWorker.java	0.00%	2 Missing ⚠️
...bernetes/cluster/KubernetesClusterManagerImpl.java	50.00%	1 Missing ⚠️
...er/actionworkers/KubernetesClusterStartWorker.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11902   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
  Complexity    15533    15533           
=========================================
  Files          5909     5909           
  Lines        529013   529021    +8     
  Branches      64605    64607    +2     
=========================================
+ Hits          92912    92916    +4     
- Misses       425652   425659    +7     
+ Partials      10449    10446    -3     

Flag	Coverage Δ
uitests	3.58% <ø> (ø)
unittests	18.63% <4.34%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15537

[harikrishna-patnala]

code LGTM

[kiranchavala]

@nvazquez

Hitting the same issue again , the cks cluster selects the systemvmtemplate for arm for deployment even if the preffered architecture is x86_64

@harikrishna-patnala is working on a fix

[harikrishna-patnala]

@nvazquez I've pushed a fix to compare the preferred arch type with template arch type, because names are different than types here

https://github.com/shapeblue/cloudstack/blob/12c077d7045174d51374fce2118422d1dcf06657/api/src/main/java/com/cloud/cpu/CPU.java#L22-L26

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15544

[kiranchavala]

LGTM

Able to deploy cks cluster on amd , arm clusters architecture

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[harikrishna-patnala]

Thanks @nvazquez tested the last commit locally, it worked fine.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15547

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[Pearl1594]

code lgtm

[blueorangutan]

[SF] Trillian test result (tid-14723)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 72213 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11902-t14723-kvm-ol8.zip
Smoke tests completed. 143 look OK, 1 have errors, 5 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpn_usage	Error	1.41	test_usage.py
all_test_human_readable_logs	Skipped	---	test_human_readable_logs.py
all_test_image_store_object_migration	Skipped	---	test_image_store_object_migration.py
all_test_import_unmanage_volumes	Skipped	---	test_import_unmanage_volumes.py
all_test_internal_lb	Skipped	---	test_internal_lb.py
all_test_ipv4_routing	Skipped	---	test_ipv4_routing.py