UI: Add info for 'Use primary storage replication' in snapshot view(s) #11943
Conversation
slavkap
left a comment
slavkap
left a comment
There was a problem hiding this comment.
havent't tested it, but the code LGTM
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11943 +/- ##
==========================================
Coverage 17.56% 17.57%
- Complexity 15542 15550 +8
==========================================
Files 5909 5913 +4
Lines 529058 529429 +371
Branches 64617 64677 +60
==========================================
+ Hits 92922 93021 +99
- Misses 425683 425944 +261
- Partials 10453 10464 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances snapshot creation UI forms by adding tooltip descriptions to storage replication and async backup fields, and updates the API parameter descriptions for storage replication. The changes improve user guidance by displaying API descriptions directly in the UI as tooltips.
- Added tooltip labels with API parameter descriptions to
useStorageReplicationandasyncbackupform fields across multiple Vue components - Updated API parameter descriptions for
useStorageReplicationin Java API command classes to be more descriptive and consistent - Removed redundant
required = falseparameters from API annotations (as false is the default) - Made a minor code style improvement in the Java ConfigKey declaration
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/views/storage/TakeSnapshot.vue | Added tooltip labels with API descriptions for useStorageReplication and asyncbackup fields |
| ui/src/views/storage/SnapshotZones.vue | Added tooltip label with API description for useStorageReplication field |
| ui/src/views/storage/FormSchedule.vue | Added tooltip label and beforeCreate hook to fetch API params for useStorageReplication field |
| server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java | Simplified ConfigKey declaration by removing redundant type parameter |
| api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmd.java | Updated description and removed redundant required parameter for useStorageReplication |
| api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java | Updated description and removed redundant required parameter for useStorageReplication |
| api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java | Updated description for useStorageReplication parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15590 |
api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java
Outdated
Show resolved
Hide resolved
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15889 |
4 participants
Description
This PR adds info in UI for 'Use primary storage replication' in snapshot view(s).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Verified the take snapshot and create recurring snapshots from UI.
How did you try to break this feature and the system with this change?