Skip to content

Conversation

@sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Nov 4, 2025

Description

This PR fixes #11125

API response for template/iso registration will have status="Processing"

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87
Copy link
Collaborator Author

sudo87 commented Nov 4, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 27.77778% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.19%. Comparing base (d53b6db) to head (abed121).

Files with missing lines Patch % Lines
...a/com/cloud/api/query/dao/TemplateJoinDaoImpl.java 27.77% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #11970   +/-   ##
=========================================
  Coverage     16.19%   16.19%           
- Complexity    13306    13307    +1     
=========================================
  Files          5657     5657           
  Lines        498467   498473    +6     
  Branches      60491    60487    -4     
=========================================
+ Hits          80702    80713   +11     
+ Misses       408783   408779    -4     
+ Partials       8982     8981    -1     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.04% <27.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15626

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@sureshanaparti sureshanaparti linked an issue Nov 4, 2025 that may be closed by this pull request
@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the getTemplateStatus() method in TemplateJoinDaoImpl to improve code readability and maintainability by simplifying the conditional logic and removing dead code.

  • Restructured the conditional logic with an early return for the DOWNLOADED state
  • Changed error string validation from null check to StringUtils.isNotBlank()
  • Removed unreachable "Successfully Installed" code path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sudo87
Copy link
Collaborator Author

sudo87 commented Nov 4, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15630

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15632

@sudo87
Copy link
Collaborator Author

sudo87 commented Nov 5, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15640

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initial status of Template/ISO is empty ("") upon creation

6 participants