Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Nov 4, 2025

Description

Fixes #9684

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.57%. Comparing base (bfc4f60) to head (77edb37).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ava/com/cloud/api/dispatch/ParamProcessWorker.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11976   +/-   ##
=========================================
  Coverage     17.56%   17.57%           
- Complexity    15540    15547    +7     
=========================================
  Files          5909     5909           
  Lines        529045   529057   +12     
  Branches      64615    64618    +3     
=========================================
+ Hits          92933    92959   +26     
+ Misses       425657   425641   -16     
- Partials      10455    10457    +2     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm (as said on the issue, we can expand on it but good as is)

@shwstppr shwstppr marked this pull request as ready for review November 6, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API] Internal DB IDs used as parameters

2 participants