sensitive information leak to log by YLChen-007 · Pull Request #12018 · apache/cloudstack

YLChen-007 · 2025-11-07T12:31:54Z

Description

This PR fixed sensitive information leak to log Fixes: #11985

codecov · 2025-11-07T13:21:49Z

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.24%. Comparing base (5bb5af4) to head (6fbc565).
⚠️ Report is 9 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...metal/networkservice/BaremetalPingPxeResource.java	0.00%	5 Missing ⚠️
utils/src/main/java/com/cloud/utils/UriUtils.java	0.00%	5 Missing ⚠️
.../networkservice/BaremetalKickStartPxeResource.java	0.00%	3 Missing ⚠️
...metal/networkservice/BaremetalDnsmasqResource.java	0.00%	2 Missing ⚠️
...nt/resource/consoleproxy/ConsoleProxyResource.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12018      +/-   ##
============================================
- Coverage     16.24%   16.24%   -0.01%     
  Complexity    13397    13397              
============================================
  Files          5658     5658              
  Lines        499224   499249      +25     
  Branches      60595    60599       +4     
============================================
+ Hits          81098    81100       +2     
- Misses       409083   409105      +22     
- Partials       9043     9044       +1

Flag	Coverage Δ
uitests	`4.03% <ø> (ø)`
unittests	`17.10% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland

clgtm, all comments nitpicking

agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java

core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java

engine/schema/src/main/java/com/cloud/upgrade/DatabaseCreator.java

...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java

...aremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java

...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java

utils/src/main/java/com/cloud/utils/UriUtils.java

…oleProxyResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

…loader.java Co-authored-by: dahn <daan.hoogland@gmail.com>

…java Co-authored-by: dahn <daan.hoogland@gmail.com>

…l/networkservice/BaremetalDnsmasqResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

…l/networkservice/BaremetalKickStartPxeResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

…l/networkservice/BaremetalPingPxeResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Co-authored-by: dahn <daan.hoogland@gmail.com>

core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java

...aremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java

github-actions · 2026-01-05T12:33:04Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…l/networkservice/BaremetalKickStartPxeResource.java Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>

DaanHoogland · 2026-01-05T13:02:39Z

@blueorangutan package

blueorangutan · 2026-01-05T13:04:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java

...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java

...aremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java

utils/src/main/java/com/cloud/utils/UriUtils.java

...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java

...aremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java

blueorangutan · 2026-01-05T14:19:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16254

nvazquez · 2026-01-26T15:15:53Z

Hi @YLChen-007 thanks for the PR - can you please address the review comments?

YLChen-007 · 2026-01-27T03:31:29Z

Hi @YLChen-007 thanks for the PR - can you please address the review comments?

Yes, I solved this problem. Please check it.

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sureshanaparti

clgtm

sureshanaparti · 2026-01-27T09:02:51Z

@blueorangutan package

blueorangutan · 2026-01-27T09:04:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-27T10:05:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16556

borisstoyanov · 2026-01-27T12:47:00Z

@blueorangutan test

blueorangutan · 2026-01-27T12:48:04Z

@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-01-28T04:12:03Z

[SF] Trillian test result (tid-15308)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52562 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12018-t15308-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_isolate_network_FW_PF_default_routes_egress_true	`Failure`	98.54	test_routers_network_ops.py

* sensitive information leak to log * Update agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java * Update core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java * Update engine/schema/src/main/java/com/cloud/upgrade/DatabaseCreator.java * Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java * Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java * Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java * Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java * Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java * Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java * Update utils/src/main/java/com/cloud/utils/UriUtils.java Co-authored-by: dahn <daan.hoogland@gmail.com> * Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com> * Sync with 4.20 and fix conflict in BaremetalPingPxeResource * Apply suggestions from code review Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> --------- Co-authored-by: chenyoulong20g@ict.ac.cn <chenyoulong20g@ict.ac.cn> Co-authored-by: dahn <daan.hoogland@gmail.com> Co-authored-by: dahn <daan@onecht.net> Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com> Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

sensitive information leak to log

1ee7c6d

boring-cyborg bot added the component:agent label Nov 7, 2025

YLChen-007 changed the base branch from main to 4.20 November 7, 2025 12:32

DaanHoogland approved these changes Nov 7, 2025

View reviewed changes

DaanHoogland added the status:needs-review label Nov 7, 2025

DaanHoogland added this to the 4.20.3 milestone Nov 7, 2025

YLChen-007 and others added 10 commits November 7, 2025 21:50

Update agent/src/main/java/com/cloud/agent/resource/consoleproxy/Cons…

7e09770

…oleProxyResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update core/src/main/java/com/cloud/storage/template/HttpTemplateDown…

08b1d9e

…loader.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update engine/schema/src/main/java/com/cloud/upgrade/DatabaseCreator.…

e084644

…java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…

4a614b6

…l/networkservice/BaremetalDnsmasqResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…

c97662d

…l/networkservice/BaremetalDnsmasqResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…

0e85b58

…l/networkservice/BaremetalKickStartPxeResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…

badf6bc

…l/networkservice/BaremetalPingPxeResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…

d9f18b6

…l/networkservice/BaremetalPingPxeResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…

460e71e

…l/networkservice/BaremetalPingPxeResource.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update utils/src/main/java/com/cloud/utils/UriUtils.java

53e1861

Co-authored-by: dahn <daan.hoogland@gmail.com>

DaanHoogland linked an issue Nov 12, 2025 that may be closed by this pull request

Credential Leakage through Logging Statements #11985

Closed

abh1sar reviewed Jan 5, 2026

View reviewed changes

core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java Outdated Show resolved Hide resolved

abh1sar reviewed Jan 5, 2026

View reviewed changes

...aremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java Outdated Show resolved Hide resolved

github-actions bot added the status:has-conflicts label Jan 5, 2026

Merge branch '4.20' into my-fix-420-mask-sensitive-information3

3393f3e

github-actions bot removed the status:has-conflicts label Jan 5, 2026

Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…

830a5a5

…l/networkservice/BaremetalKickStartPxeResource.java Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>