ceph: fix offline volume migration between ceph pools

[weizhouapache]

Description

This PR fixes #12101

tested on a env with 2 ceph primary storage

• create and start a vm, volume is on ceph-2
• stop the vm, migrate the volume to ceph-1
• start the vm, looks ok
• stop the vm, migrate the volume to ceph-2
• start the vm, looks ok

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (21d844b) to head (1cace91).
⚠️ Report is 1 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12103      +/-   ##
============================================
- Coverage     17.56%   17.56%   -0.01%     
+ Complexity    15539    15538       -1     
============================================
  Files          5909     5909              
  Lines        529097   529099       +2     
  Branches      64624    64625       +1     
============================================
  Hits          92913    92913              
- Misses       425729   425731       +2     
  Partials      10455    10455              

Flag	Coverage Δ
uitests	3.58% <ø> (ø)
unittests	18.62% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15794

[sureshanaparti]

clgtm

[Copilot]

Pull request overview

This PR fixes offline volume migration between Ceph RBD pools by ensuring the destination file path is correctly formatted when migrating from RBD to RBD storage pools.

Key Change:

• Added conditional logic to use RBDStringBuilder for destination files when the destination pool is of type RBD, ensuring proper RBD connection string formatting for both source and destination in RBD-to-RBD migrations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

thanks @sureshanaparti for review

I have verified it and updated the description.