Skip to content

Conversation

@shwstppr
Copy link
Contributor

Description

Clicking Number of connected agents shows list of connected hosts for the management server.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (671d8ad) to head (c850143).
⚠️ Report is 9 commits behind head on 4.22.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #12149   +/-   ##
=========================================
  Coverage     17.55%   17.56%           
- Complexity    15536    15544    +8     
=========================================
  Files          5909     5910    +1     
  Lines        529118   529123    +5     
  Branches      64627    64627           
=========================================
+ Hits          92902    92914   +12     
+ Misses       425761   425757    -4     
+ Partials      10455    10452    -3     
Flag Coverage Δ
uitests 3.58% <ø> (+<0.01%) ⬆️
unittests 18.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

@shwstppr , the needs-functional-definition is because it shows hosts and not SVMs, right? I think we can handle this with a hover-text hint. If this is not desired (user input required) we should just remove the link.

@shwstppr
Copy link
Contributor Author

@DaanHoogland the problem is, API/UI will return say 4 agentscount but of these 4, 2 will be hypervisor host agents and 2 system VM agents. If I add a link for either the hosts view or the system VMs view, it can be confusing. Currently, we don't have a combined view for agents' list

@DaanHoogland
Copy link
Contributor

@DaanHoogland the problem is, API/UI will return say 4 agentscount but of these 4, 2 will be hypervisor host agents and 2 system VM agents. If I add a link for either the hosts view or the system VMs view, it can be confusing. Currently, we don't have a combined view for agents' list

yes, and I see the need to deal with that, but I think for now we can remove any link or just leave as is (within this PR). We do have to create a new issue and maybe even a design discussion. I feel it should not block this fix. /me creating an issue for it.

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12149 (QA-JID-815)

@DaanHoogland
Copy link
Contributor

works in ui

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants