Skip to content

Conversation

@abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Dec 2, 2025

Description

... iso_os_type configurable in the Proxmox extension

Doc PR: apache/cloudstack-documentation#601

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Using Template:
Screenshot 2025-12-02 at 11 16 52 AM
Screenshot 2025-12-02 at 11 18 58 AM

Using ISO:
Screenshot 2025-12-02 at 11 18 40 AM
Screenshot 2025-12-02 at 11 19 05 AM

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member

@Asadsid121
this should fix #12163, can you test it ?

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (21d844b) to head (6cd4a7a).
⚠️ Report is 12 commits behind head on 4.22.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #12174   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15539    15546    +7     
=========================================
  Files          5909     5910    +1     
  Lines        529097   529128   +31     
  Branches      64624    64636   +12     
=========================================
+ Hits          92913    92940   +27     
- Misses       425729   425731    +2     
- Partials      10455    10457    +2     
Flag Coverage Δ
uitests 3.58% <ø> (+<0.01%) ⬆️
unittests 18.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Asadsid121
Copy link

@Asadsid121 this should fix #12163, can you test it ?

Yes, I have tested it and its working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CloudStack always uses local-lvm on Proxmox instead of shared storage

3 participants