Skip to content

fixed label for aclname #12196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiranchavala wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fixed label for aclname #12196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/public/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"label.accounttype": "Account type",
"label.acl.export": "Export ACL rules",
"label.acl.id": "ACL ID",
"label.aclname": "ACL Name",
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation key label.aclname is added only to en.json, but it should also be added to other locale files for consistency. Other major locale files like zh_CN.json, ja_JP.json, de_DE.json, fr_FR.json, etc., are missing this translation.

Additionally, the existing code in InfoCard.vue (line 586) and VpcTiersTab.vue (line 53) still uses $t('label.aclid') as the label while displaying the aclname value. These should be updated to use $t('label.aclname') to properly fix the label mismatch issue shown in the PR description.

Copilot uses AI. Check for mistakes.
"label.acl.rules": "ACL rules",
"label.acl.reason.description": "Enter the reason behind an ACL rule.",
"label.aclid": "ACL",
Expand Down
Loading