Skip to content

MAC address assignment improvements #12349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 4 commits into from
Jan 13, 2026

review changes

65b3572
Select commit
Loading
Failed to load commit list.
Merged

MAC address assignment improvements #12349

review changes
65b3572
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 2, 2026 in 0s

16.23% (+0.00%) compared to 4f74937

View this Pull Request on Codecov

16.23% (+0.00%) compared to 4f74937

Details

Codecov Report

❌ Patch coverage is 9.43396% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.23%. Comparing base (4f74937) to head (65b3572).

Files with missing lines Patch % Lines
.../main/java/com/cloud/network/NetworkModelImpl.java 0.00% 22 Missing ⚠️
...com/cloud/network/router/NicProfileHelperImpl.java 0.00% 5 Missing ⚠️
...ava/com/cloud/network/guru/PrivateNetworkGuru.java 0.00% 4 Missing ⚠️
.../src/main/java/com/cloud/network/NetworkModel.java 0.00% 3 Missing ⚠️
...ain/java/com/cloud/network/dao/NetworkDaoImpl.java 0.00% 2 Missing ⚠️
...ema/src/main/java/com/cloud/vm/dao/NicDaoImpl.java 0.00% 2 Missing ⚠️
...n/java/com/cloud/network/IpAddressManagerImpl.java 0.00% 2 Missing ⚠️
...va/com/cloud/network/guru/PodBasedNetworkGuru.java 0.00% 2 Missing ⚠️
...ava/com/cloud/network/guru/StorageNetworkGuru.java 0.00% 2 Missing ⚠️
...src/main/java/com/cloud/network/addr/PublicIp.java 75.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #12349   +/-   ##
=========================================
  Coverage     16.23%   16.23%           
- Complexity    13375    13380    +5     
=========================================
  Files          5657     5657           
  Lines        498875   498903   +28     
  Branches      60546    60551    +5     
=========================================
+ Hits          80982    81016   +34     
+ Misses       408866   408850   -16     
- Partials       9027     9037   +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov