Skip to content

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Jan 10, 2024

https://pre-commit.com/#4-optional-run-against-all-the-files

https://pre-commit.com/#3-install-the-git-hook-scripts

https://pre-commit.com/#pre-commit-autoupdate

Description

The Makefile will contain the three main commands for using pre-commit locally.

At least this gives you a quickstart and place to see and run the pre-commit commands.

Makefiles can be very handy perhaps in future more commands can be added.

https://en.wikipedia.org/wiki/Make_(software)

refs apache/sedona#1183

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.58%. Comparing base (dc8f465) to head (3ff62ec).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (dc8f465) and HEAD (3ff62ec). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (dc8f465) HEAD (3ff62ec)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #8491       +/-   ##
============================================
- Coverage     17.56%   3.58%   -13.98%     
============================================
  Files          5911     445     -5466     
  Lines        529359   37536   -491823     
  Branches      64655    6901    -57754     
============================================
- Hits          92979    1347    -91632     
+ Misses       425922   36025   -389897     
+ Partials      10458     164    -10294     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

ah, you are from the makestory :D

@DaanHoogland
Copy link
Contributor

looks ok, I'm not sure of the use yet. can you explain the framework in use ; yarn, make. pre-commit? is this only for use in GHA?

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 - we've GitHub actions for this, and I don't expect people to run it manually on their systems.

@jbampton jbampton marked this pull request as draft October 14, 2024 15:08
@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland
Copy link
Contributor

-1 - we've GitHub actions for this, and I don't expect people to run it manually on their systems.

I actually would expect seasoned developers to run this depending on the kind of changes they are making. that is to say the checks. if we add them to the pom file somehow that could work as well.

@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants