pre-commit: enable markdownlint rule MD018#9134
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9134 +/- ##
============================================
- Coverage 16.90% 16.06% -0.85%
Complexity 12872 12872
============================================
Files 5248 5642 +394
Lines 461567 493973 +32406
Branches 54170 59895 +5725
============================================
+ Hits 78050 79351 +1301
- Misses 374880 405837 +30957
- Partials 8637 8785 +148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jbampton
force-pushed
the
pre-commit-enable-markdownlint-MD018
branch
from
2ee987a to
6dede89
Compare
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10276 |
jbampton
force-pushed
the
pre-commit-enable-markdownlint-MD018
branch
from
49deede to
009ed10
Compare
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11335 |
|
@JoaoJandre , can we merge these linting changes (mostly by @jbampton ) during freeze? I don't think any of them have code changes. At least this one hasn't . |
@DaanHoogland I don't see why we would merge them during a freeze. Although they generally do not pose any risks (at least this one doesn't), they are also not really high priority, are they? I see no problem in waiting until we release to merge these. |
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11867 |
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11903 |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11919 |
https://github.com/DavidAnson/markdownlint/blob/main/doc/md018.md Co-authored-by: dahn <daan@onecht.net>
5 participants
https://github.com/DavidAnson/markdownlint/blob/main/doc/md018.md
Description
This PR adds another check for our Markdown linter.
MD018/no-missing-space-atx No space after hash on atx style heading.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran locally:
pre-commit run --all-filesHow did you try to break this feature and the system with this change?