make saml auth request option `forceauthn` configurable #9756

DaanHoogland · 2024-10-02T15:07:06Z

Description

This PR...

Fixes: #9701

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland · 2024-10-02T15:08:03Z

@blueorangutan package

blueorangutan · 2024-10-02T15:10:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-10-02T15:15:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (0602f46) to head (edf2413).
Report is 3 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff             @@
##               4.19    #9756     +/-   ##
===========================================
  Coverage     15.80%   15.80%             
- Complexity    11198    11199      +1     
===========================================
  Files          5038     5038             
  Lines        443852   443853      +1     
  Branches      52578    55828   +3250     
===========================================
+ Hits          70137    70138      +1     
  Misses       365912   365912             
  Partials       7803     7803

Flag	Coverage Δ
unittests	`15.80% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-10-02T16:13:38Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11257

DaanHoogland · 2024-10-03T08:57:23Z

@blueorangutan test

blueorangutan · 2024-10-03T08:58:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-04T02:18:39Z

[SF] Trillian test result (tid-11600)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60218 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9756-t11600-kvm-ol8.zip
Smoke tests completed. 136 look OK, 2 have errors, 3 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	134.12	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.12	test_vm_life_cycle.py
test_01_redundant_vpc_site2site_vpn	`Error`	542.26	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	339.74	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	339.75	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:teardown	`Error`	446.23	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	580.99	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	654.50	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py

DaanHoogland · 2024-10-04T10:49:55Z

errors seem unrelated retrying

DaanHoogland · 2024-10-04T10:50:05Z

@blueorangutan test

blueorangutan · 2024-10-04T10:52:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

...ins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java

sureshanaparti

clgtm

sureshanaparti · 2024-10-04T12:06:11Z

@vishesh92 can this be part of 4.19.2 milestone?

vishesh92 · 2024-10-04T12:10:35Z

@vishesh92 can this be part of 4.19.2 milestone?

It can be

blueorangutan · 2024-10-05T07:47:00Z

[SF] Trillian test result (tid-11615)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 73080 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9756-t11615-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	404.97	test_vm_life_cycle.py
test_02_redundant_VPC_default_routes	`Failure`	450.38	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	438.32	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	514.84	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	514.86	test_vpc_redundant.py

github-actions · 2024-10-07T13:28:05Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2024-10-07T13:31:20Z

@blueorangutan package

blueorangutan · 2024-10-07T13:32:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-07T14:32:57Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11296

DaanHoogland · 2024-10-07T18:06:50Z

@blueorangutan test

blueorangutan · 2024-10-07T18:08:06Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-08T07:50:28Z

[SF] Trillian test result (tid-11628)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47068 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9756-t11628-kvm-ol8.zip
Smoke tests completed. 129 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	0.37	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
test_10_attachAndDetach_iso	`Error`	12.93	test_vm_life_cycle.py

DaanHoogland · 2024-10-08T14:14:12Z

@blueorangutan test

blueorangutan · 2024-10-08T14:16:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-09T02:41:38Z

[SF] Trillian test result (tid-11637)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 42518 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9756-t11637-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

github-actions · 2024-10-14T06:11:47Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

rohityadavcloud · 2024-10-16T05:27:09Z

cc @JoaoJandre fwd-merging this likely security enhancement on main

DaanHoogland requested a review from vishesh92 October 2, 2024 15:07

boring-cyborg bot added the component:saml label Oct 2, 2024

DaanHoogland added this to the 4.20.1.0 milestone Oct 2, 2024

DaanHoogland added type:enhancement type:improvement labels Oct 2, 2024

vishesh92 reviewed Oct 4, 2024

View reviewed changes

...ins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManager.java Show resolved Hide resolved

sureshanaparti approved these changes Oct 4, 2024

View reviewed changes

make saml auth request option forceauthn configurable

bfcee3c

DaanHoogland force-pushed the ghi9701-samlforceauthn branch from 3227c49 to bfcee3c Compare October 7, 2024 13:27

boring-cyborg bot added component:kvm component:storage labels Oct 7, 2024

github-actions bot added the status:has-conflicts label Oct 7, 2024

DaanHoogland changed the base branch from main to 4.19 October 7, 2024 13:29

DaanHoogland modified the milestones: 4.20.1.0, 4.19.2.0 Oct 7, 2024

DaanHoogland closed this Oct 7, 2024

DaanHoogland reopened this Oct 7, 2024

github-actions bot removed the status:has-conflicts label Oct 7, 2024

DaanHoogland marked this pull request as ready for review October 9, 2024 11:42

github-actions bot added the status:has-conflicts label Oct 14, 2024

Merge branch '4.19' into ghi9701-samlforceauthn

edf2413

github-actions bot removed the status:has-conflicts label Oct 14, 2024

rohityadavcloud approved these changes Oct 16, 2024

View reviewed changes

rohityadavcloud merged commit 4459772 into apache:4.19 Oct 16, 2024
24 of 26 checks passed

rohityadavcloud deleted the ghi9701-samlforceauthn branch October 16, 2024 05:15

rohityadavcloud mentioned this pull request Oct 16, 2024

SAML: Not able to login if the user is already logged in on another application in the browser #9701

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 24, 2024

make saml auth request option forceauthn configurable (apache#9756)

d80c301

make saml auth request option forceauthn configurable #9756

make saml auth request option forceauthn configurable #9756

Uh oh!

Conversation

DaanHoogland commented Oct 2, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

DaanHoogland commented Oct 2, 2024

Uh oh!

blueorangutan commented Oct 2, 2024

Uh oh!

codecov bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 2, 2024

Uh oh!

DaanHoogland commented Oct 3, 2024

Uh oh!

blueorangutan commented Oct 3, 2024

Uh oh!

blueorangutan commented Oct 4, 2024

Uh oh!

DaanHoogland commented Oct 4, 2024

Uh oh!

DaanHoogland commented Oct 4, 2024

Uh oh!

blueorangutan commented Oct 4, 2024

Uh oh!

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Oct 4, 2024

Uh oh!

vishesh92 commented Oct 4, 2024

Uh oh!

blueorangutan commented Oct 5, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

DaanHoogland commented Oct 7, 2024

Uh oh!

blueorangutan commented Oct 7, 2024

Uh oh!

blueorangutan commented Oct 7, 2024

Uh oh!

DaanHoogland commented Oct 7, 2024

Uh oh!

blueorangutan commented Oct 7, 2024

Uh oh!

blueorangutan commented Oct 8, 2024

Uh oh!

DaanHoogland commented Oct 8, 2024

Uh oh!

blueorangutan commented Oct 8, 2024

Uh oh!

blueorangutan commented Oct 9, 2024

Uh oh!

github-actions bot commented Oct 14, 2024

Uh oh!

Uh oh!

rohityadavcloud commented Oct 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

make saml auth request option `forceauthn` configurable #9756

make saml auth request option `forceauthn` configurable #9756

codecov bot commented Oct 2, 2024 •

edited

Loading