Skip to content

Add new column last_id to the table volumes #9759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Add new column last_id to the table volumes #9759

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e53a1ce
created a new column called previous_id in the table volumes to make …
FelipeM525 Sep 30, 2024
36c88d1
changed the name of the column previous_id to last_id
FelipeM525 Oct 8, 2024
0c86f17
Update engine/schema/src/main/resources/META-INF/db/schema-41900to419…
FelipeM525 Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions engine/schema/src/main/java/com/cloud/storage/VolumeVO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ public class VolumeVO implements Volume {
@Column(name = "id")
long id;

@Column(name = "last_id")
private long lastId;

@Column(name = "name")
String name;

Expand Down Expand Up @@ -677,4 +680,12 @@ public void setExternalUuid(String externalUuid) {
public String getEncryptFormat() { return encryptFormat; }

public void setEncryptFormat(String encryptFormat) { this.encryptFormat = encryptFormat; }

public long getLastId() {
return lastId;
}

public void setLastId(long lastId) {
this.lastId = lastId;
}
}
2 changes: 2 additions & 0 deletions engine/schema/src/main/resources/META-INF/db/schema-41900to41910.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,5 @@ CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.user_data', 'removed', 'datetime COM
UPDATE `cloud`.`configuration` SET
`options` = 'FirstFitRouting,RandomAllocator,TestingAllocator,FirstFitAllocator,RecreateHostAllocator'
WHERE `name` = 'host.allocators.order';

CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('volumes','last_id', 'bigint(20) unsigned DEFAULT NULL');
Copy link
Contributor

@JoaoJandre JoaoJandre Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('volumes','last_id', 'bigint(20) unsigned DEFAULT NULL');
-- Add last_id to the volumes table
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('volumes','last_id', 'bigint(20) unsigned DEFAULT NULL');

Copy link
Member

@rohityadavcloud rohityadavcloud Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like maintainers cannot commit/merge suggested changes cc @FelipeM525

Copy link
Member

@rohityadavcloud rohityadavcloud Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this should ideally be moved to 4.19.1.0->4.19.2.0 sql path

Copy link
Contributor

@JoaoJandre JoaoJandre Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FelipeM525 👆

2 changes: 2 additions & 0 deletions ...n/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2283,6 +2283,8 @@ private void handlePostMigration(boolean success, Map<VolumeInfo, VolumeInfo> sr
if (success) {
VolumeVO volumeVO = _volumeDao.findById(destVolumeInfo.getId());
volumeVO.setFormat(ImageFormat.QCOW2);
volumeVO.setLastId(srcVolumeInfo.getId());

_volumeDao.update(volumeVO.getId(), volumeVO);

_volumeService.copyPoliciesBetweenVolumesAndDestroySourceVolumeAfterMigration(Event.OperationSuccessed, null, srcVolumeInfo, destVolumeInfo, false);
Expand Down
1 change: 1 addition & 0 deletions .../storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1720,6 +1720,7 @@ protected VolumeVO duplicateVolumeOnAnotherStorage(Volume volume, StoragePool po
newVol.setPassphraseId(volume.getPassphraseId());
newVol.setEncryptFormat(volume.getEncryptFormat());
}
newVol.setLastId(volume.getId());
return volDao.persist(newVol);
}

Expand Down