pre-commit: fix .cs files with the trailing-whitespace hook

[jbampton]

Description

This PR adds .cs files to the trailing-whitespace pre-commit hook.

This hook auto fixes and removes trailing whitespace when run locally on a users machine.

On the GitHub CI it just runs either pass or fail for now.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally: pre-commit run --all-files

How did you try to break this feature and the system with this change?

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.07%. Comparing base (0b66f5a) to head (2bfe8b7).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #9794   +/-   ##
=========================================
  Coverage     16.07%   16.07%           
  Complexity    12885    12885           
=========================================
  Files          5642     5642           
  Lines        494039   494039           
  Branches      59912    59912           
=========================================
+ Hits          79406    79408    +2     
+ Misses       405829   405828    -1     
+ Partials       8804     8803    -1     

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	16.91% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11341

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11872

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11911

[DaanHoogland]

the hyperv cs files are hardly maintained but the changes look good to me. Did you use a global search and replace for this, @jbampton ? (just want to know what I missed ;)

[jbampton]

Hey @DaanHoogland we are using the official pre-commit hook trailing-whitespace:

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#trailing-whitespace

This hook is an auto fixer and finds and removes all the trailing whitespace from the files/file types that are checked.

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11957

[DaanHoogland]

@vishesh92 , I don't see a reason to run any tests (other than GHA) on this one, agree?

[vishesh92]

@vishesh92 , I don't see a reason to run any tests (other than GHA) on this one, agree?

I agree

[vishesh92]

Lgtm