server: fix vm_stats records are not removed if batchsize is 0

[weizhouapache]

Description

Prior to this change

2024-10-17T10:32:55,455 DEBUG [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-ec4b3698]) (logid:708dd27c) Starting to remove all vm_stats rows older than [Wed Oct 16 22:32:55 UTC 2024].
2024-10-17T10:32:55,456 INFO  [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-ec4b3698]) (logid:708dd27c) Removed a total of [0] vm_stats rows older than [Wed Oct 16 22:32:55 UTC 2024].

With this change

2024-10-17T10:41:33,315 DEBUG [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-dd8d7e09]) (logid:338dd659) Starting to remove all vm_stats rows older than [Wed Oct 16 22:41:33 UTC 2024].
2024-10-17T10:43:03,184 INFO  [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-dd8d7e09]) (logid:338dd659) Removed a total of [1661329] vm_stats rows older than [Wed Oct 16 22:41:33 UTC 2024].

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (20901c7) to head (9a1bdaf).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...java/com/cloud/storage/dao/VolumeStatsDaoImpl.java	0.00%	1 Missing ⚠️
...src/main/java/com/cloud/vm/dao/VmStatsDaoImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #9818   +/-   ##
=========================================
  Coverage     15.78%   15.78%           
- Complexity    12564    12565    +1     
=========================================
  Files          5627     5627           
  Lines        492266   492250   -16     
  Branches      63860    63795   -65     
=========================================
+ Hits          77707    77710    +3     
+ Misses       406084   406066   -18     
+ Partials       8475     8474    -1     

Flag	Coverage Δ
uitests	4.04% <ø> (ø)
unittests	16.60% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rohityadavcloud]

LGTM didn't test it

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

related to
@JoaoJandre 's PR #8740
@shwstppr 's PR #8999
@vishesh92 's merge commit 3923f80#diff-1ccbb9294e1b4e876df4f865c95f8f302ccea7a2ce6cfe574d0efa76e8f88868R1238

[JoaoJandre]

LGTM

[vishesh92]

@weizhouapache We need this change in 4.19 since the PRs you mentioned are part of 4.19 branch.

[shwstppr]

code lgtm

[sureshanaparti]

clgtm

[weizhouapache]

@weizhouapache We need this change in 4.19 since the PRs you mentioned are part of 4.19 branch.

4.19 has similar change introduced in #8740 , it works

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11379

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11682)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60826 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9818-t11682-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_create_pvlan_network	Error	0.10	test_pvlan.py
test_disable_oobm_ha_state_ineligible	Error	322.16	test_hostha_kvm.py
test_hostha_configure_default_driver	Error	112.52	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected	Error	553.63	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	Error	548.49	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	Error	548.49	test_hostha_kvm.py
test_hostha_kvm_host_degraded	Error	41.62	test_hostha_kvm.py
test_hostha_kvm_host_fencing	Error	37.88	test_hostha_kvm.py
test_hostha_kvm_host_recovering	Error	35.38	test_hostha_kvm.py
test_remove_ha_provider_not_possible	Error	35.32	test_hostha_kvm.py

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[rohityadavcloud]

host_ha test failures are intermittent in nature. Let's merge this for sake of time & kick test matrix on the health check PR cc @JoaoJandre

[blueorangutan]

[SF] Trillian test result (tid-11686)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51586 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9818-t11686-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File