-
Notifications
You must be signed in to change notification settings - Fork 1.2k
VR: fix wrong check when compare two configuration files #9822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VR: fix wrong check when compare two configuration files #9822
Conversation
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #9822 +/- ##
===========================================
Coverage 12.27% 12.27%
- Complexity 9335 9336 +1
===========================================
Files 4699 4699
Lines 414691 414691
Branches 53409 51957 -1452
===========================================
+ Hits 50891 50896 +5
+ Misses 357475 357469 -6
- Partials 6325 6326 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11380 |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-11683)
|
Description
in some configuration files, the value can be set in multiple times and order matters.
For example there are two haproxy configurations
without this change, they are considered as same configuration, which is obviously wrong.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?