Fix Kubernetes cluster view when user is unable to scale #9867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9867 +/- ##
==========================================
Coverage 15.08% 15.08%
- Complexity 11201 11203 +2
==========================================
Files 5404 5404
Lines 473424 473423 -1
Branches 60702 60168 -534
==========================================
+ Hits 71418 71428 +10
+ Misses 394059 394045 -14
- Partials 7947 7950 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sureshanaparti
approved these changes
Oct 30, 2024
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Nov 20, 2024
) Co-authored-by: Henrique Sato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user does not have access to the
scaleKubernetesClusterAPI and tries to list Kubernetes clusters through the UI, an error is thrown. Therefore, it is not possible to list and create Kubernetes clusters due to this error, even if the user has permission for such actions.Since then, changes have been made so that this error no longer occurs and the user can list and manage Kubernetes clusters even if he doesn't have access to the
scaleKubernetesClusterAPI.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I created an account from a custom admin role that has the
scaleKubernetesClusterAPI asDENYand all other APIs asALLOW. Then, I logged into this account and was able to perform some basic operations like creating, listing and deleting a Kubernetes cluster.