-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Add UI support for forvpc and guestiptype parameters of the listNetworkOfferings API
#9947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add UI support for forvpc and guestiptype parameters of the listNetworkOfferings API
#9947
Conversation
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9947 +/- ##
============================================
- Coverage 15.80% 15.80% -0.01%
- Complexity 12585 12586 +1
============================================
Files 5627 5627
Lines 492343 492350 +7
Branches 59694 59694
============================================
Hits 77828 77828
- Misses 405992 405999 +7
Partials 8523 8523
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
|
@JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
kiranchavala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JoaoJandre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM, I did not test it
…listNetworkOfferings` API (apache#9947) * add guestiptype and forvpc filters for listNetworkOfferings on UI * fix duplicate option names on list filters



Description
Currently, the
listNetworkOfferingsAPI supports theforvpcandguestiptypeparameters (see API docs). The first is used to filter network offerings that can only be used for creating VPC tiers; the second allows filtering by guest network type (available options are:Isolated,SharedandL2).This PR adds support to these parameters in the UI. The
forvpcfilter has been added as a normal filter (declared in thefiltersproperty of the network offerings section's object) and theguestiptypeas a search filter (declared in thesearchFiltersproperty).Furthermore, this PR also fixes a bug that caused duplicate options to appear in search filter lists.
Fixes #9924
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
forvpcfilter testsVPCon the section's filter, a request tolistNetworkOfferingswas sent, with theforvpcparameter set totrue.Guest Networkon the section's filter, a request tolistNetworkOfferingswas sent, with theforvpcparameter set tofalse.Allon the section's filter, a request tolistNetworkOfferingswas sent, without theforvpcparameter.guestiptypefilter testsIsolatedoption on theGuest Typesearch filter, a request tolistNetworkOfferingswas sent, with theguestiptypeparameter set toIsolated.Sharedoption on theGuest Typesearch filter, a request tolistNetworkOfferingswas sent, with theguestiptypeparameter set toShared.L2option on theGuest Typesearch filter, a request tolistNetworkOfferingswas sent, with theguestiptypeparameter set toL2.Duplicate options in search filter lists
Before
After