-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Displaying info of the labels from form CreateSSHKeyPair #9970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displaying info of the labels from form CreateSSHKeyPair #9970
Conversation
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #9970 +/- ##
============================================
- Coverage 15.80% 15.80% -0.01%
Complexity 12586 12586
============================================
Files 5627 5627
Lines 492294 492344 +50
Branches 62198 59694 -2504
============================================
+ Hits 77824 77828 +4
- Misses 405946 405993 +47
+ Partials 8524 8523 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vishesh92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm. Tested in the simulator env and the changes works as expected.
Description
This PR aims to display the label hints in the
CreateSSHKeyPairform, which are currently not shown, negatively impacting the user experience.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?