Skip to content

Conversation

@LayonRibeiro
Copy link
Contributor

Description

This PR aims to display the label hints in the CreateSSHKeyPair form, which are currently not shown, negatively impacting the user experience.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before

before

After

after

How Has This Been Tested?

The label hints were displayed in the form in question.

@bernardodemarco
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9970 (QA-JID-485)

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (f7b7339) to head (cc2e1d8).
Report is 16 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20    #9970      +/-   ##
============================================
- Coverage     15.80%   15.80%   -0.01%     
  Complexity    12586    12586              
============================================
  Files          5627     5627              
  Lines        492294   492344      +50     
  Branches      62198    59694    -2504     
============================================
+ Hits          77824    77828       +4     
- Misses       405946   405993      +47     
+ Partials       8524     8523       -1     
Flag Coverage Δ
uitests 4.04% <ø> (-0.01%) ⬇️
unittests 16.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. Tested in the simulator env and the changes works as expected.

@DaanHoogland DaanHoogland changed the base branch from main to 4.20 November 28, 2024 12:22
@DaanHoogland DaanHoogland added this to the 4.20.1 milestone Nov 28, 2024
@JoaoJandre JoaoJandre merged commit a2d5aa9 into apache:4.20 Nov 28, 2024
25 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants