Skip to content

Conversation

@LayonRibeiro
Copy link
Contributor

@LayonRibeiro LayonRibeiro commented Nov 25, 2024

Description

This PR proposes adding a tooltip that displays the exact frequency (without rounding and described in MHz) of the cpuspeed and the memory value in MB to three decimal places on Hosts pages. Currently, the InfoCard component treats the CPU frequency to be displayed in GHz to two decimal places. The current way in which computing resources are displayed can mislead the end user.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before

before

After

after

How Has This Been Tested?

The tooltip with the exact frequency was displayed on the Hosts page.

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (8a2c0f3) to head (ed8ddf1).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #9971    +/-   ##
==========================================
  Coverage     15.80%   15.80%            
  Complexity    12585    12585            
==========================================
  Files          5627     5627            
  Lines        492343   492521   +178     
  Branches      59694    59733    +39     
==========================================
+ Hits          77828    77858    +30     
- Misses       405992   406136   +144     
- Partials       8523     8527     +4     
Flag Coverage Δ
uitests 4.10% <ø> (+0.06%) ⬆️
unittests 16.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9971 (QA-JID-487)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested in QA)
should we include a similar tooltip for memory?

@LayonRibeiro
Copy link
Contributor Author

lgtm (tested in QA) should we include a similar tooltip for memory?

Yes, if you prefer, I can do it myself.

@DaanHoogland
Copy link
Contributor

lgtm (tested in QA) should we include a similar tooltip for memory?

Yes, if you prefer, I can do it myself.

that is ok, either in this PR or a separate one. What you prefer. And thank you for your effort.

@sureshanaparti
Copy link
Contributor

@LayonRibeiro can this be targeted for 4.19.2? if so, please rebase with 4.19 branch. thanks.

@LayonRibeiro LayonRibeiro changed the title UI: Tooltip to display the exact CPU value of the Host in MHz (InfoCard) UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) Nov 29, 2024
@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@LayonRibeiro LayonRibeiro changed the base branch from main to 4.19 November 29, 2024 21:15
@LayonRibeiro
Copy link
Contributor Author

LayonRibeiro commented Nov 29, 2024

@LayonRibeiro can this be targeted for 4.19.2? if so, please rebase with 4.19 branch. thanks.

Done

@DaanHoogland DaanHoogland merged commit 7cfeab1 into apache:4.19 Dec 2, 2024
1 check passed
DaanHoogland added a commit that referenced this pull request Dec 3, 2024
* 4.20:
  UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) (#9971)
  UI: Allow accounts of the `User` type to add other accounts or users to projects through UI (#9927)
  enable to create VPC portfowarding rules with source cidr (#7081)
  Add new column `last_id` to the table volumes (#9759)
  Allow VMWare import via another host (#9787)
  Linstor: add support for ISO block devices and direct download (#9792)
  get expunged VM data for job result (#9949)
  fix section divider display on auth page (#9966)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
…MHz and the memory value in MB (to 3 decimal places) (apache#9971)

Co-authored-by: layon.oliveira <[email protected]>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
* 4.20:
  UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) (apache#9971)
  UI: Allow accounts of the `User` type to add other accounts or users to projects through UI (apache#9927)
  enable to create VPC portfowarding rules with source cidr (apache#7081)
  Add new column `last_id` to the table volumes (apache#9759)
  Allow VMWare import via another host (apache#9787)
  Linstor: add support for ISO block devices and direct download (apache#9792)
  get expunged VM data for job result (apache#9949)
  fix section divider display on auth page (apache#9966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants