-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) #9971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) #9971
Conversation
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9971 +/- ##
==========================================
Coverage 15.80% 15.80%
Complexity 12585 12585
==========================================
Files 5627 5627
Lines 492343 492521 +178
Branches 59694 59733 +39
==========================================
+ Hits 77828 77858 +30
- Misses 405992 406136 +144
- Partials 8523 8527 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (tested in QA)
should we include a similar tooltip for memory?
Yes, if you prefer, I can do it myself. |
that is ok, either in this PR or a separate one. What you prefer. And thank you for your effort. |
|
@LayonRibeiro can this be targeted for 4.19.2? if so, please rebase with 4.19 branch. thanks. |
6f5e312 to
af00cae
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Done |
* 4.20: UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) (#9971) UI: Allow accounts of the `User` type to add other accounts or users to projects through UI (#9927) enable to create VPC portfowarding rules with source cidr (#7081) Add new column `last_id` to the table volumes (#9759) Allow VMWare import via another host (#9787) Linstor: add support for ISO block devices and direct download (#9792) get expunged VM data for job result (#9949) fix section divider display on auth page (#9966)
…MHz and the memory value in MB (to 3 decimal places) (apache#9971) Co-authored-by: layon.oliveira <[email protected]>
* 4.20: UI: Tooltip on the host information card to display the CPU speed in MHz and the memory value in MB (to 3 decimal places) (apache#9971) UI: Allow accounts of the `User` type to add other accounts or users to projects through UI (apache#9927) enable to create VPC portfowarding rules with source cidr (apache#7081) Add new column `last_id` to the table volumes (apache#9759) Allow VMWare import via another host (apache#9787) Linstor: add support for ISO block devices and direct download (apache#9792) get expunged VM data for job result (apache#9949) fix section divider display on auth page (apache#9966)
Description
This PR proposes adding a
tooltipthat displays the exact frequency (without rounding and described in MHz) of thecpuspeedand thememoryvalue in MB to three decimal places on Hosts pages. Currently, the InfoCard component treats the CPU frequency to be displayed in GHz to two decimal places. The current way in which computing resources are displayed can mislead the end user.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?