Don't initialize instance variables to their default values

Author: garydgregory

src/main/java/org/apache/commons/beanutils/BeanComparator.java

@@ -48,12 +48,12 @@
 public class BeanComparator<T> implements Comparator<T>, Serializable {
 
     private static final long serialVersionUID = 1L;
-    
+
     /**
      * Method name to call to compare.
      */
     private String property;
-    
+
     /**
      * BeanComparator will pass the values of the specified bean property to this Comparator. If your bean property is not a comparable or contains null values,
      * a suitable comparator may be supplied in this constructor.

src/main/java/org/apache/commons/beanutils/BeanUtils.java

@@ -44,7 +44,7 @@ public class BeanUtils {
      *             this class.
      */
     @Deprecated
-    private static int debug = 0;
+    private static int debug;
 
     /**
      * <p>Clone a bean based on the available property getters and setters,

src/main/java/org/apache/commons/beanutils/ConversionException.java

@@ -33,7 +33,7 @@ public class ConversionException extends RuntimeException {
      * @deprecated Use {@link Throwable#getCause()}}.
      */
     protected Throwable cause;
-    
+
     /**
      * Constructs a new exception with the specified message.
      *

src/main/java/org/apache/commons/beanutils/DynaProperty.java

@@ -338,7 +338,7 @@ private void writeAnyClass(final Class<?> clazz, final ObjectOutputStream out) t
     /**
      * Writes this object safely. There are issues with serializing primitive class types on certain JVM versions (including java 1.3). This method provides a
      * workaround.
-     * 
+     *
      * @param out Where to write.
      * @throws IOException if I/O errors occur while writing to the underlying stream.
      */

src/main/java/org/apache/commons/beanutils/MethodUtils.java

@@ -125,7 +125,7 @@ public int hashCode() {
      * really optional we can ignore this problem; only one of the webapps
      * will get the warning in its logs but that should be good enough.
      */
-    private static boolean loggedAccessibleWarning = false;
+    private static boolean loggedAccessibleWarning;
 
     /**
      * Indicates whether methods should be cached for improved performance.

src/main/java/org/apache/commons/beanutils/PropertyUtils.java

@@ -112,7 +112,7 @@ public class PropertyUtils {
      * @deprecated The <code>debug</code> static property is no longer used
      */
     @Deprecated
-    private static int debug = 0;
+    private static int debug;
 
     /**
      * Adds a <code>BeanIntrospector</code>. This object is invoked when the

src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java

@@ -136,9 +136,9 @@ private static Map<String, Object> toPropertyMap(final Object obj) {
      * The cache of PropertyDescriptor arrays for beans we have already
      * introspected, keyed by the java.lang.Class of this object.
      */
-    private WeakFastHashMap<Class<?>, BeanIntrospectionData> descriptorsCache = null;
+    private WeakFastHashMap<Class<?>, BeanIntrospectionData> descriptorsCache;
 
-    private WeakFastHashMap<Class<?>, FastHashMap> mappedDescriptorsCache = null;
+    private WeakFastHashMap<Class<?>, FastHashMap> mappedDescriptorsCache;
 
 
     /** Log instance */

src/main/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverter.java

@@ -66,7 +66,7 @@ private static String initDefaultChars() {
 
 
     /** Should the date conversion be lenient? */
-    boolean isLenient = false;
+    boolean isLenient;
 
     /**
      * Create a {@link org.apache.commons.beanutils.locale.LocaleConverter}

src/test/java/org/apache/commons/beanutils/A.java

@@ -26,7 +26,7 @@
  */
 public class A {
 
-    boolean called = false;
+    boolean called;
 
     public void foo(final OutputStream os)
     {

src/test/java/org/apache/commons/beanutils/BeanificationTestCase.java

@@ -40,7 +40,7 @@ public class BeanificationTestCase extends TestCase {
 
     class Signal {
         private Exception e;
-        private int signal = 0;
+        private int signal;
         private BeanUtilsBean bean;
         private PropertyUtilsBean propertyUtils;
         private ConvertUtilsBean convertUtils;