org.apache.commons.cli.OptionBuilder.create() should throw

IllegalStateException instead of IllegalArgumentException

Is the state that's wrong, there are no arguments to validate anyway.

Author: garydgregory

src/changes/changes.xml

@@ -40,6 +40,7 @@
       <action type="fix" issue="CLI-347" dev="ggregory" due-to="Ruiqi Dong, Gary Gregory">Options.addOptionGroup(OptionGroup) does not remove required options from requiredOpts list.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">org.apache.commons.cli.Option.Builder.get() should throw IllegalStateException instead of IllegalArgumentException.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">org.apache.commons.cli.Option.processValue(String) should throw IllegalStateException instead of IllegalArgumentException.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">org.apache.commons.cli.OptionBuilder.create() should throw IllegalStateException instead of IllegalArgumentException.</action>
       <!-- ADD -->
       <action type="add" issue="CLI-339" dev="ggregory" due-to="Claude Warren, Gary Gregory">Help formatter extension in the new package #314.</action>
       <action type="add" dev="ggregory" due-to="Gary Gregory">CommandLine.Builder implements Supplier&lt;CommandLine&gt;.</action>

src/main/java/org/apache/commons/cli/OptionBuilder.java

@@ -72,7 +72,7 @@ public final class OptionBuilder {
     public static Option create() throws IllegalArgumentException {
         if (longOption == null) {
             reset();
-            throw new IllegalArgumentException("must specify longopt");
+            throw new IllegalStateException("must specify longopt");
         }
 
         return create(null);

src/test/java/org/apache/commons/cli/OptionBuilderTest.java

@@ -50,7 +50,7 @@ void testBaseOptionStringOpt() {
     void testBuilderIsResettedAlways() {
         assertThrows(IllegalArgumentException.class, () -> OptionBuilder.withDescription("JUnit").create('"'));
         assertNull(OptionBuilder.create('x').getDescription(), "we inherited a description");
-        assertThrows(IllegalArgumentException.class, (Executable) OptionBuilder::create);
+        assertThrows(IllegalStateException.class, (Executable) OptionBuilder::create);
         assertNull(OptionBuilder.create('x').getDescription(), "we inherited a description");
     }
 
@@ -77,7 +77,7 @@ void testCompleteOption() {
 
     @Test
     void testCreateIncompleteOption() {
-        assertThrows(IllegalArgumentException.class, (Executable) OptionBuilder::create);
+        assertThrows(IllegalStateException.class, (Executable) OptionBuilder::create);
         // implicitly reset the builder
         OptionBuilder.create("opt");
     }