Precompile and resuse regular expressions in

DaitchMokotoffSoundex.parseRules(Scanner, String, Map<Character,
List<Rule>>, Map<Character, Character>)

Author: garydgregory

src/changes/changes.xml

@@ -49,6 +49,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Refactor DigestUtils.updateDigest(MessageDigest, File) to use NIO.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory" issue="CODEC-328" >Clarify Javadoc for org.apache.commons.codec.digest.UnixCrypt.crypt(byte[],String).</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Precompile and resuse x3 regular expression in DaitchMokotoffSoundex.Rule.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Precompile and resuse regular expressions in DaitchMokotoffSoundex.parseRules(Scanner, String, Map, Map).</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add HmacUtils.hmac(Path).</action>      
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add HmacUtils.hmacHex(Path).</action>      

src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java

@@ -228,6 +228,10 @@ public String toString() {
     /** Folding rules. */
     private static final Map<Character, Character> FOLDINGS = new HashMap<>();
 
+    private static final Pattern EQUAL = Pattern.compile("=");
+
+    private static final Pattern SPACES = Pattern.compile("\\s+");
+
     static {
         try (Scanner scanner = new Scanner(Resources.getInputStream(RESOURCE_FILE), CharEncoding.UTF_8)) {
             parseRules(scanner, RESOURCE_FILE, RULES, FOLDINGS);
@@ -272,7 +276,7 @@ private static void parseRules(final Scanner scanner, final String location,
 
                 if (line.contains("=")) {
                     // folding
-                    final String[] parts = line.split("=");
+                    final String[] parts = EQUAL.split(line);
                     if (parts.length != 2) {
                         throw new IllegalArgumentException("Malformed folding statement split into " + parts.length +
                                 " parts: " + rawLine + " in " + location);
@@ -288,7 +292,7 @@ private static void parseRules(final Scanner scanner, final String location,
                     asciiFoldings.put(leftCharacter.charAt(0), rightCharacter.charAt(0));
                 } else {
                     // rule
-                    final String[] parts = line.split("\\s+");
+                    final String[] parts = SPACES.split(line);
                     if (parts.length != 4) {
                         throw new IllegalArgumentException("Malformed rule statement split into " + parts.length +
                                 " parts: " + rawLine + " in " + location);