Skip to content

Commit 1e0c381

Browse files
committed
Reuse String.isEmpty()
1 parent 10136c7 commit 1e0c381

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/main/java/org/apache/commons/jxpath/ri/NamespaceResolver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ protected static String getPrefix(final NodePointer pointer, final String namesp
4848
final String uri = nsPointer.getNamespaceURI();
4949
if (uri.equals(namespaceURI)) {
5050
final String prefix = nsPointer.getName().getName();
51-
if (!"".equals(prefix)) {
51+
if (!prefix.isEmpty()) {
5252
return prefix;
5353
}
5454
}

src/main/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.apache.commons.jxpath.ri.model.NodePointer;
3737
import org.apache.commons.jxpath.ri.model.beans.NullPointer;
3838
import org.apache.commons.jxpath.util.TypeUtils;
39+
import org.apache.commons.lang3.StringUtils;
3940
import org.w3c.dom.Attr;
4041
import org.w3c.dom.Comment;
4142
import org.w3c.dom.Document;
@@ -136,7 +137,7 @@ public static String getNamespaceURI(Node node) {
136137
aNode = aNode.getParentNode();
137138
}
138139
}
139-
return "".equals(uri) ? null : uri;
140+
return StringUtils.isEmpty(uri) ? null : uri;
140141
}
141142

142143
/**

src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ private static String getNamespaceURI(final Object node) {
117117
if (node instanceof Element) {
118118
final Element element = (Element) node;
119119
String ns = element.getNamespaceURI();
120-
if ("".equals(ns)) {
120+
if (ns.isEmpty()) {
121121
ns = null;
122122
}
123123
return ns;

0 commit comments

Comments
 (0)