JXPathContextFactoryConfigurationError now reuses its superclass'

Throwable cause

Author: garydgregory

pom.xml

@@ -117,6 +117,9 @@
             <!-- http://www.jdom.org/docs/apidocs/ is not a secure link -->
             <link>https://javadoc.io/doc/org.jdom/jdom/1.1</link>
           </links>
+          <excludePackageNames>
+            org.apache.commons.jxpath.ri.parser
+          </excludePackageNames>
         </configuration>
       </plugin>
       <plugin>

src/changes/changes.xml

@@ -117,6 +117,9 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="fix" due-to="Gary Gregory">PageScopeContext.getAttributeNames() is now typed with generics.</action>
       <action dev="ggregory" type="fix" due-to="Gary Gregory">Functions.getUsedNamespaces() is now typed with generics.</action>
       <action dev="ggregory" type="fix" due-to="Gary Gregory">JXPathException now reuses its superclass' Throwable cause.</action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory">Bump JXPathException serialVersionUID from 4306409701468017766L to 2L.</action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory">JXPathContextFactoryConfigurationError now reuses its superclass' Throwable cause.</action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory">Bump JXPathContextFactoryConfigurationError serialVersionUID from 1L to 2L.</action>
       <!-- ADD -->
       <action issue="JXPATH-123" dev="mbenson" type="add">
         XPath function "ends-with" is not implemented (although "starts-with" is).

src/main/java/org/apache/commons/jxpath/JXPathContextFactoryConfigurationError.java

@@ -23,36 +23,31 @@
  */
 public class JXPathContextFactoryConfigurationError extends Error {
 
-    private static final long serialVersionUID = 1L;
-    /** @serial */
-    private final Exception exception;
+    private static final long serialVersionUID = 2L;
 
     /**
      * Create a new {@code JXPathContextFactoryConfigurationError} with no detail mesage.
      */
     public JXPathContextFactoryConfigurationError() {
-        this.exception = null;
     }
 
     /**
      * Create a new {@code JXPathContextFactoryConfigurationError} with a given {@code Exception} base cause of the error.
      *
-     * @param e The exception to be encapsulated in a JXPathContextFactoryConfigurationError.
+     * @param cause The exception to be encapsulated in a JXPathContextFactoryConfigurationError.
      */
-    public JXPathContextFactoryConfigurationError(final Exception e) {
-        super(e.toString());
-        this.exception = e;
+    public JXPathContextFactoryConfigurationError(final Exception cause) {
+        super(cause);
     }
 
     /**
      * Create a new {@code JXPathContextFactoryConfigurationError} with the given {@code Exception} base cause and detail message.
      *
-     * @param e   The exception to be encapsulated in a JXPathContextFactoryConfigurationError
+     * @param cause   The exception to be encapsulated in a JXPathContextFactoryConfigurationError
      * @param msg The detail message.
      */
-    public JXPathContextFactoryConfigurationError(final Exception e, final String msg) {
-        super(msg);
-        this.exception = e;
+    public JXPathContextFactoryConfigurationError(final Exception cause, final String msg) {
+        super(msg, cause);
     }
 
     /**
@@ -62,7 +57,6 @@ public JXPathContextFactoryConfigurationError(final Exception e, final String ms
      */
     public JXPathContextFactoryConfigurationError(final String msg) {
         super(msg);
-        this.exception = null;
     }
 
     /**
@@ -71,21 +65,7 @@ public JXPathContextFactoryConfigurationError(final String msg) {
      * @return The encapsulated exception, or null if there is none.
      */
     public Exception getException() {
-        return exception;
+        return (Exception) super.getCause();
     }
 
-    /**
-     * Gets the message (if any) for this error . If there is no message for the exception and there is an encapsulated exception then the message of that
-     * exception will be returned.
-     *
-     * @return The error message.
-     */
-    @Override
-    public String getMessage() {
-        final String message = super.getMessage();
-        if (message == null && exception != null) {
-            return exception.getMessage();
-        }
-        return message;
-    }
 }

src/main/java/org/apache/commons/jxpath/JXPathException.java

@@ -22,7 +22,7 @@
  */
 public class JXPathException extends RuntimeException {
 
-    private static final long serialVersionUID = 4306409701468017766L;
+    private static final long serialVersionUID = 2L;
 
     /**
      * Create a new {@code JXPathException} with no detail mesage.