Migrate tests to JUnit5#214
Merged
garydgregory merged 1 commit intoapache:masterfrom Jan 7, 2025
strangelookingnerd:migrate_junit5
Merged
Migrate tests to JUnit5#214garydgregory merged 1 commit intoapache:masterfrom strangelookingnerd:migrate_junit5
garydgregory merged 1 commit intoapache:masterfrom
strangelookingnerd:migrate_junit5
Conversation
Member
|
@strangelookingnerd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates tests to JUnit5. Changes include
junit.framework.*for the JUnit5 equivalentsassertEquals(null, object)becomesassertNull(object)There would be plenty of other possible improvements and best-practises that were not implemented in order to keep the changeset minimal. If desired I could add these as well in a separate PR.
Verified with
mvn clean verifythat build passes before and after my changes.Overall number of tests and coverage did not change. Note that
org.apache.commons.jxpath.ri.model.jdom.JDOMModelTest#testIDdid not do anything so I chose to use@Disabledwith a meaningful message.