Deprecate NumberUtils.compare(int, int) in favor of Integer.compare(int,

int)

Author: garydgregory

src/changes/changes.xml

@@ -62,6 +62,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action                   type="fix" dev="ggregory" due-to="mayuming">Fix CalendarUtils.toLocalDate() Javadoc return type description #1440.</action>
     <action                   type="fix" dev="ggregory" due-to="mayuming">Fix the method name in Javadoc examples for CharUtils.isHex() #1444.</action>
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate NumberUtils.compare(byte, byte) in favor of Byte.compare(byte, byte).</action>
+    <action                   type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate NumberUtils.compare(int, int) in favor of Integer.compare(int, int).</action>
     <!-- FIX Javadoc -->
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">[javadoc] General improvements.</action>
     <action                   type="fix" dev="ggregory" due-to="Gary Gregory">[javadoc] Fix thrown exception documentation for org.apache.commons.lang3.reflect.MethodUtils.getMethodObject(Class&lt;?&gt;, String, Class&lt;?&gt;...).</action>

src/main/java/org/apache/commons/lang3/ArrayUtils.java

@@ -3714,7 +3714,7 @@ public static boolean isSorted(final int[] array) {
         final int n = array.length;
         for (int i = 1; i < n; i++) {
             final int current = array[i];
-            if (NumberUtils.compare(previous, current) > 0) {
+            if (Integer.compare(previous, current) > 0) {
                 return false;
             }
             previous = current;

src/main/java/org/apache/commons/lang3/math/NumberUtils.java

@@ -111,12 +111,11 @@ public static int compare(final byte x, final byte y) {
      *         a value less than {@code 0} if {@code x < y}; and
      *         a value greater than {@code 0} if {@code x > y}
      * @since 3.4
+     * @deprecated Use {@link Integer#compare(int, int)}.
      */
+    @Deprecated
     public static int compare(final int x, final int y) {
-        if (x == y) {
-            return 0;
-        }
-        return x < y ? -1 : 1;
+        return Integer.compare(x, y);
     }
 
     /**

src/main/java/org/apache/commons/lang3/mutable/MutableInt.java

@@ -18,8 +18,6 @@
 
 import java.util.concurrent.atomic.AtomicInteger;
 
-import org.apache.commons.lang3.math.NumberUtils;
-
 /**
  * A mutable {@code int} wrapper.
  * <p>
@@ -132,12 +130,12 @@ public int addAndGet(final Number operand) {
     /**
      * Compares this mutable to another in ascending order.
      *
-     * @param other  the other mutable to compare to, not null
-     * @return negative if this is less, zero if equal, positive if greater
+     * @param other  the other mutable to compare to, not null.
+     * @return negative if this is less, zero if equal, positive if greater.
      */
     @Override
     public int compareTo(final MutableInt other) {
-        return NumberUtils.compare(this.value, other.value);
+        return Integer.compare(this.value, other.value);
     }
 
     /**