Add LongBitField class for 64-bit operations with tests #1552
+254
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
requested changes
Jan 4, 2026
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
@theodoral22
Thank you for the PR. Some minor comments to address throughout.
| * System.out.println(high8.getValue(value)); // 0x56 | ||
| * </pre> | ||
| * | ||
| * @since 3.13 (example) |
| } | ||
|
|
||
| /** | ||
| * Obtains the value for the specified LongBitField, unshifted. |
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class LongBitFieldTest { |
Member
There was a problem hiding this comment.
The class and test methods should not be public to follow JUnit 5 guidelines.
| public long setValue(final long holder, final long value) { | ||
| return holder & ~mask | (value << shiftCount) & mask; | ||
| } | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
The file must end in an empty line.
| public void testSetBoolean() { | ||
| LongBitField field = new LongBitField(0x1000L); // bit 12 | ||
| long holder = 0x0000L; | ||
|
|
| } | ||
|
|
||
| /** | ||
| * Replaces the bits with new values. |
| /** | ||
| * Tests whether any bit in the field is set. | ||
| * | ||
| * @param holder the long data containing the bits |
Member
There was a problem hiding this comment.
Sentences should end in a period.
Author
|
Thank you for reviewing my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new class
LongBitFieldthat extends the concept ofBitFieldto support 64-bit values (long).The existing
BitFieldonly supportsint,shortandbyte, which is insufficient for modern use cases involving large flags or 64-bit bitsets.Features
set,clear,setBoolean,getValue,getRawValue,isSet,isAllSet.longvalues to allow 64-bit flags.LongBitFieldTest.java, covering:-> Single-bit and multi-bit masks
-> Edge cases (lowest and highest bits)
-> Boolean set/clear operations
-> Setting and getting values
BitFieldAPI for easy adoption.Motivation
int). Many modern applications require 64-bit flags or large bitsets.longvalues.Testing
LongBitFieldTest.java.