Skip to content

LANG-1386 #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ester-bloch wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Draft

LANG-1386 #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/apache/commons/lang3/BooleanUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ public class BooleanUtils {
* @throws IllegalArgumentException if {@code array} is empty.
* @since 3.0.1
*/
public static boolean and(final boolean... array) {

public static boolean and(boolean[] array) {
Copy link
Copy Markdown

@isachinshah isachinshah Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this as final.
We will not be allowed to modify the reference and work with another array by mistake.
Otherwise we will be busy debugging why our changes are not persisted/reflected after the method call.

ObjectUtils.requireNonEmpty(array, "array");
for (final boolean element : array) {
if (!element) {
Expand Down
10 changes: 10 additions & 0 deletions src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,16 @@ void testAnd_object_emptyInput() {
assertIllegalArgumentException(() -> BooleanUtils.and(new Boolean[] {}));
}

@Test
void testAnd_object_varargs_wrapper() {
assertEquals(false, BooleanUtils.and(Boolean.FALSE, Boolean.TRUE));
}

@Test
void testAnd_object_varargs_primitive() {
assertEquals(false, BooleanUtils.and(false, true));
}

@Test
void testAnd_object_nullElementInput() {
assertEquals(Boolean.FALSE, BooleanUtils.and(new Boolean[] {null}));
Expand Down