refactor: replace fs-extra with node:fs#1772
Merged
erisu merged 3 commits intoapache:masterfrom Jan 29, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1772 +/- ##
=======================================
Coverage 72.50% 72.50%
=======================================
Files 23 23
Lines 1837 1837
=======================================
Hits 1332 1332
Misses 505 505 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpogue
reviewed
Jan 28, 2025
dpogue
approved these changes
Jan 28, 2025
Member
dpogue
left a comment
There was a problem hiding this comment.
Created a project and ran prepare & build with this locally and it all seems to be working 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
n/a
Motivation and Context
Replace
fs-extradependency with node internalsnode:fsDescription
Remove
fs-extraand updated code to require and usenode:fsAPIs.Testing
npm tChecklist
(platform)if this change only applies to one platform (e.g.(android))