feat!: add partial night & day theme support#1818
Merged
erisu merged 2 commits intoapache:masterfrom Jul 7, 2025
Merged
Conversation
1928ec3 to
3ba2c22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1818 +/- ##
==========================================
+ Coverage 72.12% 72.24% +0.11%
==========================================
Files 23 23
Lines 1844 1841 -3
==========================================
Hits 1330 1330
+ Misses 514 511 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OS-kepatotorica
pushed a commit
to OutSystems/cordova-android
that referenced
this pull request
Oct 8, 2025
* feat!: partial night & day theme support * feat!: prefix core resource values files with cdv_
OS-kepatotorica
pushed a commit
to OutSystems/cordova-android
that referenced
this pull request
Oct 22, 2025
* feat!: partial night & day theme support * feat!: prefix core resource values files with cdv_
OS-kepatotorica
pushed a commit
to OutSystems/cordova-android
that referenced
this pull request
Oct 24, 2025
* feat!: partial night & day theme support * feat!: prefix core resource values files with cdv_
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
cdv_*to avoid issues caused by plugins that either create or modify the same files.This should also:
Resolves #1485
Cover SplashScreen & Background Color. (SystemBars, such as Status Bar & Gesture/Navigation Bar, will be handled in a separate PR)
Description
res/values/cdv_colors.xmlcolors.xml.cdv_background_colorset to#FAF8FF. Same values as SDK 34+.cdv_splashscreen_backgroundset to@color/cdv_background_colorto match background color.res/values-v34/cdv_colors.xmlcdv_background_colorset to@android:color/system_background_light.cdv_splashscreen_backgroundset to@color/cdv_background_colorto match background color.res/values-night/cdv_colors.xmlcdv_background_colorset to#121318. Same values as SDK 34+.cdv_splashscreen_backgroundset to@color/cdv_background_colorto match background color.res/values-night-v34/cdv_colors.xmlcdv_background_colorset to@android:color/system_background_dark.cdv_splashscreen_backgroundset to@color/cdv_background_colorto match background color.res/values/cdv_themes.xmlthemes.xml.postSplashScreenThemedefault value@style/Theme.Cordova.App.DayNight.Theme.Cordova.App.DayNightnew theme withandroid:colorBackgroundset to@color/cdv_background_colorres/values/cdv_strings.xmlcdv_strings.xml.SplashScreen background color can be set by the following preferences, in the order of priority:
AndroidWindowSplashScreenBackgroundSplashScreenBackgroundColorBackgroundColorPreviously when the preferences was set and
cordova preparewas executed,colors.xmlwould have been updated.Now,
cdv_themes.xmlwould be updated instead with the#RRGGBBor#AARRGGBBvalue inserted into the SplashScreenswindowSplashScreenBackground. Since Cordova only accepted one color value for the SplashScreen background, it was easier to change the theme instead of the four colors resource files.Testing
npm tChecklist
(platform)if this change only applies to one platform (e.g.(android))