Skip to content

Conversation

@GitToTheHub
Copy link
Contributor

  • This class is not used anywhere within the codebase
  • This class was created for backward compatibility with plugins written for cordova-android 5.0.0+ to work with earlier versions (pre-5.0.0)
  • This should be removed for cordova-android 15

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- This class is not used anywhere within the codebase
- This class was created for backward compatibility with plugins written for cordova-android 5.0.0+ to work with earlier versions (pre-5.0.0)
- This should be removed for cordova-android 15
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.79%. Comparing base (cab5c5b) to head (aca2a9a).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1856       +/-   ##
===========================================
- Coverage   72.12%   60.79%   -11.33%     
===========================================
  Files          23       23               
  Lines        1844     4811     +2967     
===========================================
+ Hits         1330     2925     +1595     
- Misses        514     1886     +1372     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu
Copy link
Member

erisu commented Oct 27, 2025

The PermissionHelper class is not actually obsolete and should not be deleted. This helper class is used by plugins.

Here are some examples:

Above points to the imports but if you scan the file you will see it being used.

While the above are Cordova core plugins, I believe many third-party plugins also use it.

@GitToTheHub
Copy link
Contributor Author

GitToTheHub commented Oct 28, 2025

But the PermissionHelper is deprecated and obsolete anyway, or? Because you must not use it can directly call everything on the CordovaInterface of the CordovaPlugin. I would mark everything in the PermissionHelper as deprecated, what do you think?

@GitToTheHub
Copy link
Contributor Author

I deprecated the PermissionHelper in this PR: #1857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants