Skip to content

Remove unused private Method PermissionHelper.deliverPermissionResult #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove unused private Method PermissionHelper.deliverPermissionResult #1858

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f1e195
Remove unused private Method PermissionHelper.deliverPermissionResult
GitToTheHub Oct 28, 2025
4dd78c0
Remove unused private Method PermissionHelper.deliverPermissionResult
GitToTheHub Oct 28, 2025
3489815
Merge branch 'pr-remove-unused-method-deliverpermissionresult-in-perm…
GitToTheHub Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions framework/src/org/apache/cordova/PermissionHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ Licensed to the Apache Software Foundation (ASF) under one
* written for cordova-android 5.0.0+ can still compile with earlier cordova-android versions.
*/
public class PermissionHelper {
private static final String LOG_TAG = "CordovaPermissionHelper";

/**
* Requests a "dangerous" permission for the application at runtime. This is a helper method
* alternative to cordovaInterface.requestPermission() that does not require the project to be
Expand Down Expand Up @@ -71,18 +69,4 @@ public static void requestPermissions(CordovaPlugin plugin, int requestCode, Str
public static boolean hasPermission(CordovaPlugin plugin, String permission) {
return plugin.cordova.hasPermission(permission);
}

private static void deliverPermissionResult(CordovaPlugin plugin, int requestCode, String[] permissions) {
// Generate the request results
int[] requestResults = new int[permissions.length];
Arrays.fill(requestResults, PackageManager.PERMISSION_GRANTED);

try {
// This one is deprecated - see https://github.com/apache/cordova-android/issues/592
plugin.onRequestPermissionResult(requestCode, permissions, requestResults);
plugin.onRequestPermissionsResult(requestCode, permissions, requestResults);
} catch (JSONException e) {
LOG.e(LOG_TAG, "JSONException when delivering permissions results", e);
}
}
}