-
Notifications
You must be signed in to change notification settings - Fork 345
chore(coverage): Move from nyc to c8 for code coverage #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'd like to open this PR after PR #666 would be merged. |
|
Can you run When I run the following: I see a change to the Basically, Previously, with But as |
|
This might be caused by mistake in rebase. I made sure that I got same result |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 65.53% 72.68% +7.15%
==========================================
Files 3 3
Lines 235 615 +380
==========================================
+ Hits 154 447 +293
- Misses 81 168 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erisu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Platforms affected
n/a
Motivation and Context
nyc doesn't seem to be actively maintained. c8 is an alternative that relies on node itself to provide coverage information rather than trying to inject instrumentation into the code.
Description
Move from nyc to c8
Testing
npm t
Checklist
(platform)if this change only applies to one platform (e.g.(android))