Skip to content

Comments

Plugin Guide: Notes for --link option#1416

Closed
GitToTheHub wants to merge 3 commits intoapache:masterfrom
GitToTheHub:pr-plugin-guide-link-option-notice
Closed

Plugin Guide: Notes for --link option#1416
GitToTheHub wants to merge 3 commits intoapache:masterfrom
GitToTheHub:pr-plugin-guide-link-option-notice

Conversation

@GitToTheHub
Copy link
Contributor

Added notice, that the linking only works, when the plugin is added after a platform was added and that the linking will be lost if a platform is re-added

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Added notice, that the linking only works, when the plugin is added after a platform was added and that the linking will be lost if a platform is re-added
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend adding this to the dev directory as well to ensure that it will exist in future snapshots

GitToTheHub and others added 2 commits June 8, 2025 13:37
- Change wording
- Link will also be lost during restoring

Co-authored-by: エリス <erisu@users.noreply.github.com>
@GitToTheHub
Copy link
Contributor Author

I created a new pr for this: #1419
Because I couldn't squash the commits

@GitToTheHub GitToTheHub closed this Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants