Ios video save and camera facing option#311
Open
aman-geekybunch wants to merge 7 commits intoapache:masterfrom
Open
Ios video save and camera facing option#311aman-geekybunch wants to merge 7 commits intoapache:masterfrom
aman-geekybunch wants to merge 7 commits intoapache:masterfrom
Conversation
Added support for back and front camera during video capture
Added options frontFacing?: number; and saveToGallery?: number; so that we can use front camera to record video and save video to gallery
set value to default for testing
Made values default to TRUE is not set
comparison of bool fix
Changed true to YES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
We required functionality to switch to frnt facing camera by default in one of our ionic app.
Description
We aded to param to Video option, SaveToGallery and frontFacing that will allows user to control camera face while capturing video
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))