fix: new MediaFile() - fix wrong property name for localURL#54
Open
tanasebutcaru wants to merge 2 commits intoapache:masterfrom
Open
fix: new MediaFile() - fix wrong property name for localURL#54tanasebutcaru wants to merge 2 commits intoapache:masterfrom
tanasebutcaru wants to merge 2 commits intoapache:masterfrom
Conversation
janpio
changed the title
janpio
requested changes
Jul 4, 2019
Member
janpio
left a comment
janpio
left a comment
There was a problem hiding this comment.
Hard merge conflict, unsurprisingly after so much time.
Has to be checked if has already be fixed in the meantime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If manually created a
MediaFileobject and callinggetFormatDataon it, it will run into an error with code 2 (invalid argument).MediaFileextends theFileconstructor, which does not have afilePathproperty.