feat(ios): Implement property 'quality' in captureImage() (CB-11630)#66
Open
ryanwilliams83 wants to merge 1 commit intoapache:masterfrom
Open
feat(ios): Implement property 'quality' in captureImage() (CB-11630)#66ryanwilliams83 wants to merge 1 commit intoapache:masterfrom
ryanwilliams83 wants to merge 1 commit intoapache:masterfrom
Conversation
… JPEG compression quality
Member
|
Is there anything comparable in one of our other plugins? |
Member
|
Is there anything comparable in one of our other plugins?
What do you mean?
Is there an equivalent feature possible for Android
Haven’t searched for such a feature yet. And besides android the other plugins would need to be check, too.
What happens on Android when this param is supplied, which is not support there (yet)?
Hmm 🤔
The android thing could indeed lead to issues, since quality is parsed from the JSON as an integer:
https://github.com/apache/cordova-plugin-media-capture/blob/master/src/android/PendingRequests.java#L191
…Sent from my iPhone
On 7. May 2019, at 12:04 AM, Jan Piotrowski ***@***.***> wrote:
Is there anything comparable in one of our other plugins?
Is there an equivalent feature possible for Android?
What happens on Android when this param is supplied, which is not support there (yet)?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
This is not the only plugin taking pictures. Does e.g. camera plugin have similar functionality? If so, does the API match? |
RealDrewKlayman
approved these changes
Nov 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
Allows developers to set JPEG compression quality
What testing has been done on this change?
captureImage()
'quality' omitted / 0 / 0.0 / 0.1 / 0.3 / 0.5 / 0.96 / 0.99 / 1 / 100
Checklist