Do not call success callbackon Android when Activity is signaled to be destroyed. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en onDestroyed(..) is invoked by Android OS. Providing parameter in destroy method to allow for silent player destruction. Player does not broadcast state change when handler is destroyed. Player emits media aborted error when handler is destroyed.
janpio
changed the title
|
Will this ever make it in? |
|
Still? Can you at least provide an adjudication on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Success callback is not called on Android when Activity is signaled to be destroyed. Instead, an error message (ABORTED) is signaled to client. This helps to clear up the ambiguity during a common android activity life cycle event (onDestroy), because previously the client code was unable to discern the reason for a successful callback execution. The reasons for a success callback could possibly be for activity termination OR playback naturally coming to an end (EOF reached).