feat(browser): Use FadeSplashScreenDuration from config.xml on browser platform#151
feat(browser): Use FadeSplashScreenDuration from config.xml on browser platform#151royalrex wants to merge 4 commits intoapache:masterfrom
Conversation
IgneButene
left a comment
IgneButene
left a comment
There was a problem hiding this comment.
This is exactly what I need - 1s is way too long for splash-screen, especially on the browser.
src/browser/SplashScreenProxy.js
Outdated
| innerLocalSplash.style["-webkit-transition"] = | ||
| innerLocalSplash.style["-moz-transition"] = | ||
| innerLocalSplash.style["-ms-transition"] = | ||
| innerLocalSplash.style["-o-transition"] = transitionCssString; |
There was a problem hiding this comment.
Uh, does this work this way with foo = bar = baz = value;?
There was a problem hiding this comment.
The other thing I'd like to discuss: Do we even need the prefixes besides for the IE? Looking at caniuse (https://caniuse.com/#feat=css-transitions) the only browser which does not support it unprefixed is the IE <10
There was a problem hiding this comment.
I guess prefixes could be left out .. just didn't want to mess too much with the code.
janpio
left a comment
janpio
left a comment
There was a problem hiding this comment.
Looks good, needs manual testing though.
janpio
changed the title
# Conflicts: # src/browser/SplashScreenProxy.js
|
Updated this PR so it can be merged after being left for ~2.5yrs 🙈 |
royalrex
requested review from
janpio and
timbru31
and removed request for
timbru31
4 participants
Platforms affected
Browser
What does this PR do?
Use FadeSplashScreenDuration from config.xml on browser platform
What testing has been done on this change?
Manually added the plugin code to production app and published. No errors discovered.
Checklist