Skip to content

Conversation

@milenkovicm
Copy link
Contributor

@milenkovicm milenkovicm commented Nov 23, 2024

there was a bit of repeatibility in the test, same tests were used for standalone and remote context.

this PR introduces:

  • rstest to parametrise tests, so we can re-use tests for standalone and remote
  • enable previously ignored tests due to unsupported functionality (like INSERT INTO) to catch if datafusion brings new changes
  • testcontainers tests moved to example to reduce duplication (they are still disabled as i could not make them connect to docker deamon)

Which issue does this PR close?

Closes none.

Rationale for this change

simplification and de-duplication of tests

What changes are included in this PR?

  • rstest to parametrise tests, so we can re-use tests for standalone and remote
  • enable previously ignored tests due to unsupported functionality (like INSERT INTO) to catch if datafusion brings new changes
  • testcontainers tests moved to example to reduce duplication (they are still disabled as i could not make them connect to docker deamon)

follow up PR will move files to centralised location as there may be few duplicates

Are there any user-facing changes?

No, just tests

... use rstest to run same tests for standalone
and remote.
@milenkovicm milenkovicm changed the title refactor: re-consolidate ballista tests refactor: consolidate ballista tests Nov 23, 2024
@andygrove andygrove merged commit c649907 into apache:main Nov 24, 2024
16 checks passed
@milenkovicm milenkovicm deleted the refactor_tests branch November 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants